1555302 - nsStandardURL::Resolve should not treat tel: URIs as relative

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-a3958638-574d-438d-861a-dc09e0190529.

Top 10 frames of crashing thread:

0 xul.dll NS_NewURI netwerk/base/nsNetUtil.cpp:1874
1 xul.dll NS_NewURI netwerk/base/nsNetUtil.cpp:1632
2 xul.dll NS_NewURI netwerk/base/nsNetUtil.cpp:1658
3 xul.dll nsContentUtils::NewURIWithDocumentCharset dom/base/nsContentUtils.cpp:2859
4 xul.dll nsGenericHTMLElement::GetURIAttr dom/html/nsGenericHTMLElement.cpp:1435
5 xul.dll mozilla::dom::HTMLAnchorElement::GetHrefURI dom/html/HTMLAnchorElement.cpp:242
6 xul.dll mozilla::dom::Link::LinkState dom/base/Link.cpp:372
7 xul.dll mozilla::dom::Document::FlushPendingLinkUpdatesFromRunnable dom/base/Document.cpp:9962
8 xul.dll nsresult mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void  xpcom/threads/nsThreadUtils.h:1177
9 xul.dll nsresult IdleRunnableWrapper::Run xpcom/threads/nsThreadUtils.cpp:331

There are 11 crashes (from 4 installations) in nightly 69 starting with buildid 20190528214841. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1536744.
The moz_cras_reason is always: MOZ_RELEASE_ASSERT(newScheme == scheme)
I can reliably reproduce it with url: https://phonebook.mozilla.org/?search/anne
But it's ok in replacing "anne" by "calixte" or "valentin".

[1] https://hg.mozilla.org/mozilla-central/rev?node=d418e0d5594a

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1555302 - Ensure that nsStandardURL::Resolve() doesn't parse URLs with a different scheme as relative r=mayhemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32f9907bf1f7
Ensure that nsStandardURL::Resolve() doesn't parse URLs with a different scheme as relative r=mayhemer

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 32f9907bf1f7 (Bug 1555302) for causing permafailures in dom/url/tests/test_url.html CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=249796917
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=249798175

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249796917&repo=autoland&lineNumber=7481
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249798175&repo=autoland&lineNumber=1496

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3ec1f61c75e
Backed out changeset 32f9907bf1f7 for causing permafailures in  dom/url/tests/test_url.html CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c154027b928
Ensure that nsStandardURL::Resolve() doesn't parse URLs with a different scheme as relative r=mayhemer

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2c154027b928