Closed
Bug 1555354
Opened 5 years ago
Closed 5 years ago
Conditional Panel should not have a focus input border
Categories
(DevTools :: Debugger, defect, P5)
DevTools
Debugger
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jlast, Assigned: soniasingla)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(3 files)
Screen Shot 2019-05-29 at 10.03.55 AM.png
One small pet-peeve of mine is that we show a focus border around the input when it is opened. We can remove it with CSS, which will preserve the initial intent of the design
|
Reporter | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
Keywords: good-first-bug
Priority: -- → P5
|
Assignee | |
Comment 2•5 years ago
|
||
I would like to work on this issue.
Thanks
Sonia
|
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → soniasingla.1812
|
||
Comment 3•5 years ago
|
||
|
|
||
Comment 4•5 years ago
|
||
Hello Sonia! I created a patch for this here:
https://phabricator.services.mozilla.com/D36413
I’d love your review or tips for improvement!
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Hello David !
I revised the patch, it looks good to me :)
I have some suggestion. Conditional panel could have block for the input to enter. I have attached screenshot with it. May be we can implement it in the future.
Sorry for the late reply, my hardware machine got crashed :P
Thanks
Sonia
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62808544679f Prevent debug line from displaying in conditional panel r=jlast
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•