Closed Bug 1555354 Opened 3 months ago Closed Last month

Conditional Panel should not have a focus input border

Categories

(DevTools :: Debugger, defect, P5)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: jlast, Assigned: soniasingla.1812)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(3 files)

One small pet-peeve of mine is that we show a focus border around the input when it is opened. We can remove it with CSS, which will preserve the initial intent of the design

Keywords: good-first-bug
Priority: -- → P5

I would like to work on this issue.

Thanks
Sonia

Assignee: nobody → soniasingla.1812

Hello Sonia! I created a patch for this here:

https://phabricator.services.mozilla.com/D36413

I’d love your review or tips for improvement!

Hello David !

I revised the patch, it looks good to me :)
I have some suggestion. Conditional panel could have block for the input to enter. I have attached screenshot with it. May be we can implement it in the future.

Sorry for the late reply, my hardware machine got crashed :P

Thanks
Sonia

Blocks: 1565711
Blocks: 1565713
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62808544679f
Prevent debug line from displaying in conditional panel r=jlast
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.