1555354 - Conditional Panel should not have a focus input border

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P5)

Description

[Jason Laster [:jlast]]

One small pet-peeve of mine is that we show a focus border around the input when it is opened. We can remove it with CSS, which will preserve the initial intent of the design

Comment 1

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-05-29 at 10.03.55 AM.png

Comment 2

[Sonia Singla :soniasingla]

I would like to work on this issue.

Thanks
Sonia

Comment 3

[David Walsh :davidwalsh]

Attachment: Bug 1555354 - Prevent debug line from displaying in conditional panel r=jlast

Comment 4

[David Walsh :davidwalsh]

Hello Sonia! I created a patch for this here:

https://phabricator.services.mozilla.com/D36413

I’d love your review or tips for improvement!

Comment 5

[Sonia Singla :soniasingla]

Attachment: Screenshot from 2019-07-07 22-01-05.png

Comment 6

[Sonia Singla :soniasingla]

Hello David !

I revised the patch, it looks good to me :)
I have some suggestion. Conditional panel could have block for the input to enter. I have attached screenshot with it. May be we can implement it in the future.

Sorry for the late reply, my hardware machine got crashed :P

Thanks
Sonia

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62808544679f
Prevent debug line from displaying in conditional panel r=jlast

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/62808544679f