1555483 - Implement blend SVG filter in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/feBlend

The most interesting thing about this filter is that's the first one to take multiple inputs. Markus' API proposal in https://github.com/servo/webrender/issues/1880#issue-265615077 seems like a good api for expressing this. I'm not sure on the details of making that work on the WebRender side but I suspect nical can come up with something reasonable.

Comment 1

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - [WIP] Part 1: Allow webrender filter inputs to be explicitly defined

Comment 2

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 5: Combine blend and flood into a single render task and shader

Comment 3

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 1: Add SVG filter primitive display item. r?gw

Comment 4

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 2: Add SVG filter picture composite mode r?gw

Depends on D34087

Comment 5

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 3: Add blend render task and shader.

Depends on D34088

Comment 6

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 4: Implement flood filter primitive

Depends on D34089

Comment 7

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 3: Add SVG render task and shader r?gw

Depends on D34088

Comment 8

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 4: Implement blur shader primitive

Depends on D34091

Comment 9

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 4: Sanitize filter primitives r?gw

Depends on D34091

Comment 10

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555483 - Part 5: Add wrench reftests for SVG filters and update test expectations r?gw

Depends on D35741

Comment 11

[Connor Brewster [:cbrewster]]

Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebf2ccf554eab14585c6128bd58baaeebfcb9128

Blend is implemented with this patch, but most of the Gecko reftests rely on Flood which is set to use the software fallback instead of WebRender.
Since most Gecko blend reftests will use the fallback, I added a wrench reftest to test some basic use-cases for blend.
I plan to enable support for using WebRender for flood filter primitives in the future, but it will likely be separate from this bug.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a1e5a56759b
Part 1: Add SVG filter primitive display item. r=gw
https://hg.mozilla.org/integration/autoland/rev/d6169482c913
Part 2: Add SVG filter picture composite mode r=gw
https://hg.mozilla.org/integration/autoland/rev/5618213e2196
Part 3: Add SVG render task and shader r=gw
https://hg.mozilla.org/integration/autoland/rev/4d4f45f7f1d1
Part 4: Sanitize filter primitives r=gw
https://hg.mozilla.org/integration/autoland/rev/244b23c635c5
Part 5: Add wrench reftests for SVG filters and update test expectations r=gw

Comment 13

[Dorel Luca [:dluca]]

Backed out 5 changesets (bug 1555483) for Wrench failure in sdcard/wrench/reftests/border/no-aa.yaml

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255630006&repo=autoland&lineNumber=954

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=244b23c635c55f567960042f1aef1fbab3861b7b

Backout:
https://hg.mozilla.org/integration/autoland/rev/7756a16551203ca7f9214ac5132f2a25f9812f85

Comment 14

[Connor Brewster [:cbrewster]]

The test failure that caused the back out was unrelated, see Bug 1564677

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c43dc769da7
Part 1: Add SVG filter primitive display item. r=gw
https://hg.mozilla.org/integration/autoland/rev/134a51a0e034
Part 2: Add SVG filter picture composite mode r=gw
https://hg.mozilla.org/integration/autoland/rev/418839320ab5
Part 3: Add SVG render task and shader r=gw
https://hg.mozilla.org/integration/autoland/rev/917f800e4e43
Part 4: Sanitize filter primitives r=gw
https://hg.mozilla.org/integration/autoland/rev/8149efc1f813
Part 5: Add wrench reftests for SVG filters and update test expectations r=gw

Comment 16

[Noemi Erli[:noemi_erli]]

Backed out 5 changesets (Bug 1555483) for causing wrench bustages CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8149efc1f8131d09db617e82c9e6fbde25cccd0c&searchStr=wrench

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255799901&repo=autoland&lineNumber=2864

Backout: https://hg.mozilla.org/integration/autoland/rev/27679131d486cb10ecb6337688db6e84cc8b48e4

Comment 17

[Connor Brewster [:cbrewster]]

Part 5 had some images that were committed without any contents, this is now fixed.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7c4129a85163904d85cf63f1e3045fd9ba70d44

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31009157a5b4
Part 1: Add SVG filter primitive display item. r=gw
https://hg.mozilla.org/integration/autoland/rev/6c311d8365d2
Part 2: Add SVG filter picture composite mode r=gw
https://hg.mozilla.org/integration/autoland/rev/6db240b7d056
Part 3: Add SVG render task and shader r=gw
https://hg.mozilla.org/integration/autoland/rev/27c68f16f91f
Part 4: Sanitize filter primitives r=gw
https://hg.mozilla.org/integration/autoland/rev/b810038f5eb1
Part 5: Add wrench reftests for SVG filters and update test expectations r=gw

Comment 19

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/31009157a5b4
https://hg.mozilla.org/mozilla-central/rev/6c311d8365d2
https://hg.mozilla.org/mozilla-central/rev/6db240b7d056
https://hg.mozilla.org/mozilla-central/rev/27c68f16f91f
https://hg.mozilla.org/mozilla-central/rev/b810038f5eb1

Comment 20

[Connor Brewster [:cbrewster]]

Blend is now supported by WebRender, but Gecko is not using it yet. I opened bug 1573994 to track updating Gecko to use these new SVG filter primitives.