1555562 - Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[(no longer active)]

LocalStorageManager::PrecacheStorage() currently passes in aPrincipal for the storage principal argument to GetStorageInternal(). This means that if the storage object gets preloaded it won't get partitioned in the third-party context.

(For background on what storage principal means, please see https://groups.google.com/forum/#!topic/mozilla.dev.platform/b8A8LrQGOYs)

Thankfully the only caller of this function has the storage principal readily available just by calling GetEffectiveStoragePrincipal(), so it should be quite straightforward to fix this by adding a aStoragePrincipal argument to this method similar to many others in this file.

Nihanth, do you feel like taking a stab at this? :-)

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

I'm away until Monday June 3, but happy to take a look when I'm back. I'll leave the needinfo flag to remind myself.

Comment 2

[(no longer active)]

No problem, there is no rush! Thanks.

Comment 3

[(no longer active)]

Looks like this is needed for bug 1556093 too... :-/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1555562 - Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal. r=ehsan

Depends on D32916

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d39a023bdbb6
Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal. r=Ehsan

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d39a023bdbb6