Migrate AboutPreferences to use fluent
Categories
(Firefox :: New Tab Page, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | unaffected |
| firefox69 | --- | fixed |
People
(Reporter: Mardak, Assigned: jcarlos)
References
Details
Attachments
(1 file)
This might want its own fluent file, and it'll need some way for about:preferences page to use that file. We probably want the fluent file to be in the activity-stream repository for now (and copied over to browser/locales/en-US/browser for localization when done)
We can probably dynamically add something like <link rel=localization href="newtab/preferences.ftl">
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
flod, how should we approach this? Looks like the options are:
- migrate to separate newtab/preferences.ftl (or some other name or just the newtab/newtab.ftl)
- migrate to preferences/preferences.ftl
- ??
There's a ~15 properties strings that we inject into about:preferences (setting dom attributes / textcontent):
https://github.com/mozilla/activity-stream/blob/fd3c7cbd8beb11cb650f31a016c853f6f4f80e11/locales-src/en-US/strings.properties#L87-L119
about:preferences#home also has some strings that are already fluent:
https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/browser/locales/en-US/browser/preferences/preferences.ftl#455-499
Moving the properties to a separate newtab/preferences.ftl allows github-based development and string changes to happen together (instead of needing to land strings first). Although with bug 1552007 for mc-based development (and that aboutpreferences.jsm is a plain module), we could just say only make string changes (to preferences.ftl and aboutpreferences.jsm) using m-c.
|
||
Comment 2•5 years ago
|
||
I think their natural place would be with other preferences strings (preferences/preferences.ftl).
If that's a problem, then it should be a separate file just for preferences, because we'll need to load it into preferences, and no point in loading the entire newtab bundle.
|
|
||
Comment 3•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c5b35e851d6 Migrate about preferences home content to use fluent r=fluent-reviewers,Mardak,pdahiya,flod
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•