1555951 - Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task, P3)

Description

[Dão Gottwald [::dao]]

We couldn't easily import AppConstants.jsm into tabbox.xml, but in tabbox.js this is a no-brainer.

Comment 1

[Brian Grinstead [:bgrins]]

Definitely one of the benefits of moving into JS. We should be able to remove pretty much all of the non-XBL consumers of this regexp: https://searchfox.org/mozilla-central/search?q=%2FMac%2F.test&path=.

Comment 2

[Dão Gottwald [::dao]]

Attachment: Bug 1555951 - Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts. r=bgrins

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d0ccb92fae0
Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts. r=bgrins

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7d0ccb92fae0

Comment 5

[Geoff Lankow (:darktrojan)]

--- a/toolkit/content/widgets/tree.js
+++ b/toolkit/content/widgets/tree.js
@@ -551,17 +553,17 @@
       }
 
       this.setAttribute("hidevscroll", "true");
       this.setAttribute("hidehscroll", "true");
       this.setAttribute("clickthrough", "never");
 
       this.initializeAttributeInheritance();
 
-      this.pageUpOrDownMovesSelection = !/Mac/.test(navigator.platform);
+      this.pageUpOrDownMovesSelection = AppConstants.platform == "macosx";
 
       this._inputField = null;
 
       this._editingRow = -1;
 
       this._editingColumn = null;
 
       this._columnsDirty = true;

This should be AppConstants.platform != "macosx"; and has broken ctrl+click on <tree>. :-(