Closed
Bug 1555951
Opened 4 years ago
Closed 4 years ago
Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts
Categories
(Toolkit :: XUL Widgets, task, P3)
Toolkit
XUL Widgets
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
We couldn't easily import AppConstants.jsm into tabbox.xml, but in tabbox.js this is a no-brainer.
Comment 1•4 years ago
|
||
Definitely one of the benefits of moving into JS. We should be able to remove pretty much all of the non-XBL consumers of this regexp: https://searchfox.org/mozilla-central/search?q=%2FMac%2F.test&path=.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Use AppConstants.platform instead of /Mac/.test(navigator.platform) in tabbox.js → Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7d0ccb92fae0 Use AppConstants.platform instead of RegExp::test(navigator.platform) in custom element scripts. r=bgrins
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Comment 5•4 years ago
|
||
--- a/toolkit/content/widgets/tree.js
+++ b/toolkit/content/widgets/tree.js
@@ -551,17 +553,17 @@
}
this.setAttribute("hidevscroll", "true");
this.setAttribute("hidehscroll", "true");
this.setAttribute("clickthrough", "never");
this.initializeAttributeInheritance();
- this.pageUpOrDownMovesSelection = !/Mac/.test(navigator.platform);
+ this.pageUpOrDownMovesSelection = AppConstants.platform == "macosx";
this._inputField = null;
this._editingRow = -1;
this._editingColumn = null;
this._columnsDirty = true;
This should be AppConstants.platform != "macosx";
and has broken ctrl+click on <tree>
. :-(
Assignee | ||
Updated•4 years ago
|
Iteration: --- → 69.4 - Jun 24 - Jul 7
Points: --- → 1
You need to log in
before you can comment on or make changes to this bug.
Description
•