1558721 - Ctrl+click on <tree> is broken

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Geoff Lankow (:darktrojan)]

I found a mistake in the patch for bug 1555951, which has broken selecting multiple items in a <tree> by holding Ctrl and clicking.

Mistake is here: https://hg.mozilla.org/mozilla-central/rev/7d0ccb92fae0#l6.41

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1558721 - Fix ctrl+click on XUL <tree> elements

Comment 2

[Geoff Lankow (:darktrojan)]

FYI Jorg, this is why the folder-display tests are failing.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: D34664.patch

Same patch as in Phab. r=mossop from Phab review.

Comment 4

[Dão Gottwald [:dao]]

Lando is blocking landing, saying: "Diff does not have proper author information in Phabricator. See the Lando FAQ for help with this error."

Comment 5

[Jorg K (CEST = GMT+2)]

Yes, we know that. See bug 1553957 comment #15, bug 1553124 comment #4, bug 1551707 comment #3, bug 1549980 comment #6, just to quote a few :-(

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5ecd72f76c
Fix ctrl+click on XUL <tree> elements; r=Mossop

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bd5ecd72f76c