1556357 - 3.11 - 26.07% sessionrestore / startup_about_home_paint / ts_paint (linux64-shippable-qr) regression on push 284dca344fcc2736acc3c2d8bc54befea0a8ce73 (Fri May 31 2019)

Status: RESOLVED DUPLICATE of bug 1528332

(Core :: Graphics: WebRender, defect, P2)

Description

[Ionuț Goldan [:igoldan]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=284dca344fcc2736acc3c2d8bc54befea0a8ce73

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

26% ts_paint linux64-shippable-qr opt e10s stylo 226.92 -> 286.08
4% sessionrestore linux64-shippable-qr opt e10s stylo 946.17 -> 987.33
3% startup_about_home_paint linux64-shippable-qr opt e10s stylo 1,193.92 -> 1,231.08

Improvements:

5% displaylist_mutate linux64-shippable-qr opt e10s stylo 3,786.35 -> 3,606.32
4% tp5o_scroll linux64-shippable-qr opt e10s stylo 2.74 -> 2.63
4% tsvgx linux64-shippable-qr opt e10s stylo 251.37 -> 241.80
4% tscrollx linux64-shippable-qr opt e10s stylo 1.84 -> 1.78

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21240

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Darkspirit]

https://wiki.mozilla.org/Buildbot/Talos/Tests#ts_paint

type: Startup
data: 20 times we start the browser and time how long it takes to paint the startup test page, resulting in 1 set of 20 data points.

• bug 1315715 was caused by enabling the GPU process for Windows.
• bug 1528332 + bug 1530951 comment 1 are about Linux startup (shader compilation/shader cache).

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Let's just try turning on the shader cache on Linux and see what happens...

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=43dfc8df9b48fdca55b56af48cf05b5b1706b4a7

Comment 3

[Darkspirit]

26% ts_paint linux64-shippable-qr opt e10s stylo 226.92 -> 286.08

Context: Still better than Windows. https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000&series=mozilla-central,1938117,1,1&series=mozilla-central,1937825,1,1&series=mozilla-central,1934589,1,1&series=mozilla-central,1934561,1,1&series=mozilla-central,2054072,1,1

---

bug 1549965 comment 11: Yet another improvement (besides stability), if numbers are correct: https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000&series=mozilla-inbound,1960833,1,4&series=mozilla-inbound,1960983,1,4&series=mozilla-inbound,1960783,1,4&series=mozilla-inbound,1960883,1,4&series=mozilla-inbound,2033014,1,4

---

Let's just try turning on the shader cache on Linux and see what happens...

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=43dfc8df9b48fdca55b56af48cf05b5b1706b4a7&selectedTimeRange=172800
Which system configuration is used for this test? Is Wayland/EGL not tested?

For me, Nightly starts in 1 second. But with gfx.webrender.program-binary-disk;true it always takes 3 seconds with my main profile.
Debian Testing, KDE, X11, Macbook Pro A1502

Description Mesa DRI Intel(R) Iris 6100 (Broadwell GT3)
Vendor ID 0x8086
Device ID 0x162b
Driver Vendor mesa/i965
Driver Version 18.3.4.0
RAM 3072MB

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Any updates on this bug?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 6

[Darkspirit]

Should this be wontfixed or duped to bug 1528332 as there are no specific plans for this bug?
bug 1315715 (GPU Process for Windows) was wontfixed as well.
bug 594876 won't be enabled by default, WebRender/Linux is Nightly-only so far.
Improvements outweigh regressions (comment 3: ts_paint is still worse on Windows and MacOS).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I'm inclined to agree that this is probably a wontfix or dupe, but I'd rather someone from the WR team officially made that call :)