1556375 - Can't close tab that isn't currently selected

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jonathan Kamens]

When I click the little "X" on a tab that isn't currently visible, it doesn't go away. When I click the tab to make it visible and then click the "X", it does.

Regressed:

36:16.80 INFO: No more inbound revisions, bisection finished.
36:16.80 INFO: Last good revision: ac121e4bba12a4b47de324c7d0653124ff8d3cb8
36:16.80 INFO: First bad revision: 69ac929f4cbbe773fa321c0d501bb7731dcad62f
36:16.80 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=ac121e4bba12a4b47de324c7d0653124ff8d3cb8&tochange=69ac929f4cbbe773fa321c0d501bb7731dcad62f

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1556375_tab-close-issue.patch

Comment 2

[Jonathan Kamens]

What feedback are you asking me for? I'm not qualified to review the patch.

Comment 3

[Khushil Mistry [:khushil324]]

(In reply to Jonathan Kamens from comment #2)

What feedback are you asking me for? I'm not qualified to review the patch.

Just the UI review/feedback.

Comment 4

[Jonathan Kamens]

I'm sorry, but I don't understand.

I am not qualified to review the code or approach of your fix in any way.

If you're asking me to actually try it out and see if it works, there's no try build here for me to download and try out, so I can't do that either.

This is not a request I've ever gotten before after reporting a bug. I think perhaps you might be confusing me with someone who has more involvement and familiarity with Thunderbird development than I actually do.

Comment 5

[Magnus Melin [:mkmelin]]

Hmm, bug 1553614 made it just an image (like firefox). Can we keep that?

So the issue here is that bug 1546332 and bug 1553614 were in the works almost the same time, so bug 1546332 happened to remove some code that bug 1553614 moved?

Comment 6

[Khushil Mistry [:khushil324]]

(In reply to Magnus Melin [:mkmelin] from comment #5)

Hmm, bug 1553614 made it just an image (like firefox). Can we keep that?

Yes, I have changed it to image in this patch.

So the issue here is that bug 1546332 and bug 1553614 were in the works almost the same time, so bug 1546332 happened to remove some code that bug 1553614 moved?

Yes.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9069716 [details] [diff] [review]
Bug-1556375_tab-close-issue.patch

Review of attachment 9069716 [details] [diff] [review]:
-----------------------------------------------------------------

Right, looks good! r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5116ce5bc260
Fix issue with tab closing. r=mkmelin