1556726 - Navbar height increase by few pixels when select a container tab if system font size set bigger

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Alice0775 White]

Attachment: screenshot, normal tab selected vs container tab selected

Steps To Reproduce:

1. Windows10 Start > Settings >
   Click on Ease of Access > Click on Display > Make text bigger > Set 125%
2. Start Firefox
3. In customize mode, select Density > Compact
4. Open a normal tab and a container tab
5. Switch tabs
   --- observe, Navbar height

Actual Results:
See attached screenshot, Height of Navbar is increased

Expected results:
Height of Navbar should not changed

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3c18f9c43688b2fae55cc8d6f2f788c4787881ac&tochange=7389f9de8f2140532b0f2023e850347632f0bced

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1556726 - Ensure #userContext-label doesn't increase the height of the address bar. r=jkt

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb49998aa499
Ensure #userContext-label doesn't increase the height of the address bar. r=jkt

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fb49998aa499

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9070232 [details]
Bug 1556726 - Ensure #userContext-label doesn't increase the height of the address bar. r=jkt

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9070232 [details]
Bug 1556726 - Ensure #userContext-label doesn't increase the height of the address bar. r=jkt

small css fix, approved for 68.0b9

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/12ee29714942

Comment 9

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed on latest Beta 68.0b9 (64-bit) and Nightly 69.0a1 (2019-06-11) on Windows 10 x64.