1556745 - browser_privatebrowsing_about.js times out with fix for bug 1549930

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Henri Sivonen (:hsivonen)]

browser_privatebrowsing_about.js times out with fix for bug 1549930. See https://treeherder.mozilla.org/#/jobs?repo=try&revision=9af7514ecbcced4213fdcc49ab447f711ec773e1 which contains the patch from bug 1549930 comment 46, so that patch did not resolve the issue.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1556745 - browser_privatebrowsing_about.js times out with fix for bug 1549930

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:groovecoder, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Mark Banner (:standard8)]

I noticed this a while ago whilst I was working on some of the private browsing UI. Eventually got around to testing it on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b16dadc3942364ebb7d82230519533572832c7&selectedJob=273278928

It looks like it perma fails test-verify on most platforms, and at least intermittent on fission on Linux, possibly with the same error.

So I think we should try enabling it everywhere apart from those, and see if any intermittents show up etc. We can file fresh bugs for fixing it for test-verify & fission. For now, something is probably better than nothing.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1556745 - Enable browser_privatebrowsing_about.js on everything apart from test-verify and fission. r?r1cky

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/349580d635e5
Enable browser_privatebrowsing_about.js on everything apart from test-verify and fission. r=r1cky

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/349580d635e5