1592544 - Enable browser_privatebrowsing_about.js on Fission and test-verify

Status: NEW

(Firefox :: Private Browsing, defect, P1)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #1556745 +++

Bug 1549930 re-enabled browser_privatebrowsing_about.js generally, but it still seemed to be failing on Fission and test verify.

See https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b16dadc3942364ebb7d82230519533572832c7&selectedJob=273278928 for the last lot of try server failures.

Note that we are meant to be getting tests working on Fission at the moment.

There seemed to be three types failures that might occur. The first was seen on Linux fission, and on Test-verify. It could be an intermittent failure:

[task 2019-10-28T16:11:07.962Z] 16:11:07     INFO - Entering test bound setup
[task 2019-10-28T16:11:07.962Z] 16:11:07     INFO - Leaving test bound setup
[task 2019-10-28T16:11:07.962Z] 16:11:07     INFO - Entering test bound test_myths_link
[task 2019-10-28T16:11:07.963Z] 16:11:07     INFO - Buffered messages finished
[task 2019-10-28T16:11:07.963Z] 16:11:07     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Uncaught exception - TypeError: content.document.getElementById(...) is null
[task 2019-10-28T16:11:07.965Z] 16:11:07     INFO - Leaving test bound test_myths_link

The second was only seen on test-verify:

[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Buffered messages logged at 16:22:51
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Entering test bound setup
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Leaving test bound setup
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Entering test bound test_myths_link
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Buffered messages logged at 16:22:52
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - TEST-PASS | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Clicking private-browsing-myths opened https://example.com/private-browsing-myths in the same tab. - 
[task 2019-10-28T16:22:53.332Z] 16:22:53     INFO - Leaving test bound test_myths_link
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - Entering test bound test_search_icon
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - Buffered messages finished
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Should have the correct icon URL for the logo - null == "--newtab-search-icon:url(moz-extension://d81d8c67-1cb7-4843-9794-5e5abdc98e1f/favicon.ico);" - 
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - Stack trace:
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - resource://testing-common/content-task.js line 110 > eval:null:4
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - resource://testing-common/content-task.js:null:111
[task 2019-10-28T16:22:53.333Z] 16:22:53     INFO - Leaving test bound test_search_icon

and the third also on test-verify:

[task 2019-10-28T15:56:35.545Z] 15:56:35     INFO - Buffered messages logged at 15:56:33
[task 2019-10-28T15:56:35.545Z] 15:56:35     INFO - Entering test bound setup
[task 2019-10-28T15:56:35.545Z] 15:56:35     INFO - Leaving test bound setup
[task 2019-10-28T15:56:35.545Z] 15:56:35     INFO - Entering test bound test_myths_link
[task 2019-10-28T15:56:35.545Z] 15:56:35     INFO - Buffered messages logged at 15:56:34
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Version: 2.1 INTEL-12.9.22
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Vendor: Intel Inc.
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - FBO Texture Target: TEXTURE_2D
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Buffered messages finished
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js | Clicking private-browsing-myths opened https://example.com/private-browsing-myths in the same tab. - Got about:privatebrowsing, expected https://example.com/private-browsing-myths
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - Stack trace:
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochikit/content/browser-test.js:test_is:1312
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:testLinkOpensUrl:21
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js:test_myths_link:59
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1067
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1102
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:930
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-10-28T15:56:35.546Z] 15:56:35     INFO - GECKO(1734) | [Child 1738, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 42
[task 2019-10-28T15:56:35.547Z] 15:56:35     INFO - GECKO(1734) | [Child 1738, Main Thread] WARNING: Trying to request nsIHttpChannel from DocumentChannelChild, this is likely broken: file /builds/worker/workspace/build/src/netwerk/ipc/DocumentChannelChild.cpp, line 42
[task 2019-10-28T15:56:35.547Z] 15:56:35     INFO - GECKO(1734) | [Child 1738, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp, line 575
[task 2019-10-28T15:56:35.547Z] 15:56:35     INFO - Leaving test bound test_myths_link

Comment 1

[:ehsan akhgari]

(In reply to Mark Banner (:standard8) from comment #0)

Note that we are meant to be getting tests working on Fission at the moment.

What's the priority of this, asking for triage purposes?

Comment 2

[Mark Banner (:standard8)]

(In reply to :ehsan akhgari from comment #1)

(In reply to Mark Banner (:standard8) from comment #0)

Note that we are meant to be getting tests working on Fission at the moment.

What's the priority of this, asking for triage purposes?

The original post said tomorrow. I don't know if that's changed or not.

Comment 3

[:ehsan akhgari]

Thanks, then marking this as P1 and tentatively assigning to you. :-) Please let me know if you're not the right assignee (appreciate if you'd lmk who'd be a good person in that case please). Thanks!

Comment 4

[Mark Banner (:standard8)]

Heh, unfortunately I haven't got time for this at the moment, and I'm not really working on the private browsing side of things - I did the original bug as I happened to notice it as I passed by on some other work. Maybe Ricky can look at it?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Sorry, I haven't done any Firefox stuff in months since I moved to a new project.

Comment 6

[:ehsan akhgari]

Andrew, any chance you could please help find an owner for this Fission mochitest bug please? Thanks!

Comment 7

[Andrew Overholt [:overholt]]

I think someone on Wennie's team is best positioned to own this.

Comment 8

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 9

[Wennie]

This is going to circular. Luke can take a look at this, but he will need Ehsan's help to figure it out.

Comment 10

[Chris Peterson [:cpeterson]]

Blocks Fission mochitests milestone (M4.1)