1556829 - The version comparator still uses invalid values in the presence of large numbers

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Dave Townsend [:mossop]]

In bug 1555179 I attempted to correct things where version strings contain numbers larger than 32-bits by normalizing that case to 0. But I failed to notice that the function we use to parse the number actually supports 64-bit numbers, its just that we then stuff the 64-bit number into a 32-bit variable. So bug 1555179 actually only corrects parsing >64-bit numbers. For 32-bit to 64-bit numbers we still get an incorrect value.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1556829: Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3627356da98
Convert version numbers larger or smaller than the 32-bit limit to 0. r=froydnj

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b3627356da98