Closed Bug 1556895 Opened 3 months ago Closed 2 months ago

Convert first run strings in about:welcome and startup overlay to use fluent

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Status
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: pdahiya, Assigned: jcarlos)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

No description provided.
Iteration: --- → 69.3 - Jun 10 - 23
Priority: -- → P1

Looking at the code asrouter refers to react-intl here https://github.com/mozilla/activity-stream/blob/master/content-src/asrouter/asrouter-content.jsx#L1 to add locale data for StartupOverlay. Renaming this bug to convert strings used in first run about:welcome and startup overlay

Summary: Convert CFR strings to use fluent → Convert first run strings in about:welcome and startup overlay to use fluent

If this would touch the "control" and "sync" branch that uses properties strings, this might not be necessary depending on when bug 1558284 happens.

See Also: → 1558284

Good to know, Bug 1558284 is blocked on choosing a default behavior for 68 uplift and 69+ in Bug 1552280. We can pick this bug in the very end of fluent conversion bugs and depending on 1552280 status decide if we want to convert temporarily or remove these strings.

We decided that we want to keep control around for a little bit longer in case we need to revert the default, so we'll migrate the properties strings to fluent onboarding.ftl.

We can actually do this on the fluent branch instead of directly in m-c as we'll just copy over the ftl files as part of normal buildmc.

There's some helper Trailhead jsx that uses properties_id but when they're all fluent ones, we should be able to use bug 1561091's FluentOrText

Assignee: nobody → jcarlos
Type: defect → task
Iteration: 69.3 - Jun 10 - 23 → 69.4 - Jun 24 - Jul 7
Depends on: 1561091
Component: Activity Streams: Newtab → New Tab Page
Blocks: 1563243
Component: New Tab Page → Messaging System
Status: NEW → RESOLVED
Closed: 2 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.