1556895 - Convert first run strings in about:welcome and startup overlay to use fluent

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Comment 1

[Punam Dahiya [:pdahiya]]

Looking at the code asrouter refers to react-intl here https://github.com/mozilla/activity-stream/blob/master/content-src/asrouter/asrouter-content.jsx#L1 to add locale data for StartupOverlay. Renaming this bug to convert strings used in first run about:welcome and startup overlay

Comment 2

[Ed Lee :Mardak]

If this would touch the "control" and "sync" branch that uses properties strings, this might not be necessary depending on when bug 1558284 happens.

Comment 3

[Punam Dahiya [:pdahiya]]

Good to know, Bug 1558284 is blocked on choosing a default behavior for 68 uplift and 69+ in Bug 1552280. We can pick this bug in the very end of fluent conversion bugs and depending on 1552280 status decide if we want to convert temporarily or remove these strings.

Comment 4

[Ed Lee :Mardak]

We decided that we want to keep control around for a little bit longer in case we need to revert the default, so we'll migrate the properties strings to fluent onboarding.ftl.

We can actually do this on the fluent branch instead of directly in m-c as we'll just copy over the ftl files as part of normal buildmc.

There's some helper Trailhead jsx that uses properties_id but when they're all fluent ones, we should be able to use bug 1561091's FluentOrText

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5139

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/fe000c5de938