1552280 - Update default 68+ about:welcome experience including cards for return-to-AMO

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

We don't want this for 67.* but assuming we go with one of the new trailhead flows based on the outcome of bug 1545802, we'll at least want to set the default experience for release users to be something other than "control". And at the same time, we should probably make return-to-amo at least show the same cards experience (i.e., cards above search box).

Comment 1

[Ed Lee :Mardak]

Oh, this will most likely require mozilla-central/firefox.js default pref changes:

https://searchfox.org/mozilla-central/rev/94c6b5f06d2464f6780a52f32e917d25ddc30d6b/browser/app/profile/firefox.js#1329-1333

#ifdef NIGHTLY_BUILD
pref("trailhead.firstrun.branches", "join-privacy");
#else
pref("trailhead.firstrun.branches", "control");
#endif

Comment 2

[Kate Hudson :k88hudson]

In order to wait for analysis from 67.0.1, we would like to target 68 Beta 12 for this uplift

Comment 3

[Ed Lee :Mardak]

Aaron, originally this bug was filed to also update return-to-amo cards which currently shows the add-on install modal followed by the 3 non-trailhead cards modal then the new tab page.

For 68 uplift, the smallest beta change would be to set the override pref to the desired branch, e.g., join-privacy (which is currently the default on nightly) but this would not affect return-to-amo. Is that acceptable or should we update that path to show 3 trailhead cards that push down new tab content?

Comment 4

[Ed Lee :Mardak]

We will probably want to fix up return-to-amo soon anyway as part of bug 1558284 if we don't fix it here. Just that we need to get a fix for here landed and verified in nightly before we can uplift to beta 68, and bug 1558284 clean up doesn't need to be uplifted.

Comment 5

[Aaron Benson]

(In reply to Ed Lee :Mardak from comment #3)

Aaron, originally this bug was filed to also update return-to-amo cards which currently shows the add-on install modal followed by the 3 non-trailhead cards modal then the new tab page.

For 68 uplift, the smallest beta change would be to set the override pref to the desired branch, e.g., join-privacy (which is currently the default on nightly) but this would not affect return-to-amo. Is that acceptable or should we update that path to show 3 trailhead cards that push down new tab content?

Cross-posting from our discussion: I think my preferred flow would be (in order of preference):

1. amo modal -> trailhead cards on new tab (if possible).
2. amo modal -> 3 trailhead cards in old modal -> New tab page
3. amo modal -> 3 old card modal -> new tab

Jim was curious of the numbers for this particular flow to help determine how we should prioritize it.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1552280 - Update default 68+ about:welcome experience including cards for return-to-AMO

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87fb6dc17bf
Update default 68+ about:welcome experience including cards for return-to-AMO r=k88hudson

Comment 9

[Ed Lee :Mardak]

Comment on attachment 9072742 [details]
Bug 1552280 - Update default 68+ about:welcome experience including cards for return-to-AMO

Beta/Release Uplift Approval Request

• User impact if declined: Users would see the old blue control welcome messaging instead of the new Join Firefox trailhead experience
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) open 68 with a new profile
  expect: join modal then "browse privately, protection from tracking, take your passwords everywhere" cards at the top of new tab

testing RTAMO:

1. configure return to amo attribution on the executable
2. open 68 with a new profile
   expect: addon modal then "add-ons, private browsing, screenshots" cards in modal then new tab

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just using the same preference that has been on nightly except keeping "control" for return-to-amo experience
• String changes made/needed: none

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a87fb6dc17bf

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9072742 [details]
Bug 1552280 - Update default 68+ about:welcome experience including cards for return-to-AMO

about:welcome update for 68.0b12

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/492b330e047c

Comment 13

[Rares Doghi, Desktop QA]

Hi guys, We can confirm this issue verified as Fixed but for both beta 68 and Nightly 69 we are getting a different modal window.

in the expected results :

open 68 with a new profile
expect: addon modal then "add-ons, private browsing, screenshots" cards in modal then new tab

Our Actual results are: "Private Browsing, Screenshots and Sync"
Is this the correct model window ? should we see a different one ? including Add-ons ? please see the attached file.

Comment 14

[Rares Doghi, Desktop QA]

Attachment: 2019-06-21_15h39_07.png

Comment 15

[Rares Doghi, Desktop QA]

Ed can you please take a look and confirm its the right modal window before we mark this issue verified as fixed ?

Comment 16

[Ed Lee :Mardak]

Oh yup, the sync one is expected in the 3rd spot as we would otherwise not offer sync on about:welcome.

Comment 17

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in Both Beta 68 as well as our Latest Nightly 69. I will mark this issue accordingly.

Comment 18

[Ed Lee :Mardak]

Attachment: privacy cards

To be clear, attachment 9073184 [details] is the cards shown after Return to AMO. With the change here, almost all new users will see the join modal with the privacy cards (attached).