1556965 - [Dark] The login-list header has improper opacity set

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of issue

Preconditions:
browser.in-content.dark-mode is True
signon.management.page.enabled is True

Affected versions:

• Latest Nightly 69.0a1 (2019-06-04) (64-bit)
• Latest Beta 68.0b7 (64-bit)

Affected Platforms:
Windows 10 x64
Mac OS 10.14

Steps to reproduce:

• Launch Firefox and enable the prefs
• Go to about:logins
• Create new entries until the list becomes scrollable
• Scroll the entries list and observe the Header

Expected result:
The header should have a better opacity set.

Actual result:
See attached screenshot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556965 - Truncate the origin and username to 50 characters in the login-list. r?MattN

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556965 - Fix up some of the alignment of items in the login-list, header, and login-item. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556965 - Add the proper spacing and fix the width of the top-border for the meta information. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1556965 - Move the scrolling from the login-list element to the OL element inside of the login-list so the header won't be positioned above the list when scrolling. r?MattN

This fixes the issue of a translucent header showing the text through.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/079859fbd56c
Truncate the origin and username to 50 characters in the login-list. r=MattN
https://hg.mozilla.org/integration/autoland/rev/2d345a25ec29
Fix up some of the alignment of items in the login-list, header, and login-item. r=MattN
https://hg.mozilla.org/integration/autoland/rev/bab080644cde
Add the proper spacing and fix the width of the top-border for the meta information. r=MattN
https://hg.mozilla.org/integration/autoland/rev/9e0a187b064a
Move the scrolling from the login-list element to the OL element inside of the login-list so the header won't be positioned above the list when scrolling. r=MattN

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/079859fbd56c
https://hg.mozilla.org/mozilla-central/rev/2d345a25ec29
https://hg.mozilla.org/mozilla-central/rev/bab080644cde
https://hg.mozilla.org/mozilla-central/rev/9e0a187b064a

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Nightly 69.0a1 (2019-06-12) (64-bit) on Windows 10x64 and Mac OS 10.14.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we need to uplift to Beta? Please nominate it if so.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

This feature won't be released until v70, so we don't need to uplift this.