1556976 - Zooming with ctrl-wheel_scroll works on text but not other areas inside a button

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Fanolian]

Attachment: testcase.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190604214415

Steps to reproduce

1. Open the attached testcase.
2. Hover cursor on button text. Zoom with ctrl-wheelscroll.
3. Zoom by ctrl-wheelscrolling around the button text in the button.

Actual result

The page zooms if the cursor is on the button text but not on the area around the text.
This creates an undesired effect when the button (text) is pushed away by other elements. Cursor is no longer hovering on text and zoom stops abruptly.

As per bug 1199861, Disabling zoom-by-mousewheel on buttons is intended (bug 65355). This bug report is about the inconsistency of the zooming behaviour inside a button.

Expected result

Either the whole button is not zoomable by mouse wheel like before; or it is zoomable similar to Chrome/Edge. (I do not have Safari for testing.)

Comment 1

[Fanolian]

Last "good" Nightly (whole button non-zoomable): 2018-12-11
First "bad" Nightly (zoomable on button text): 2018-12-12
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac7f3beb633340c6b3fea25059e8b8aa52b5fc8a&tochange=6f21533f643edc0729216fcc1a2fd6c1b638e536

Further bisection:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f6eebcc14c22762f521fb567a9588963b8720592&tochange=61570c16c2d564c24fab36713fb169c4144453e9

The range includes bug 1089326, bug 1498383, bug 1511388, and bug 1512259.
Marking this bug report as a regression by bug 1089326 as it is the most likely one.

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

This is a regression in 66, wontfix for 67.

Comment 3

[Edgar Chen [:edgar]]

This looks like a regression of bug 1089326, maybe Olli has some idea what goes wrong here.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix in 68 but we could still potentially take a patch for 69/70.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

In a way this is a regression from bug 65355

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

And disabling zoom "works" only in some rare cases, like when mouse is over the border of input element or textarea etc.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(I have a patch for this, just need to find time to write test)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1556976, remove an old, mostly non-working hack to prevent zoom on form controls, r=masayuki

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

(trying to push the patch to tryserver, but './mach try chooser' is broken for me atm. clobbering and bootstrapping and rebuilding....)

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

(FWIW, that try chooser error is https://bugzilla.mozilla.org/show_bug.cgi?id=1603561 )

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00c1a4e337699ac04b9528f205fa4165f183c397

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1278171b29c80da729ffbe6dbfe350ffa1d8294

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f7039ca819d
remove an old, mostly non-working hack to prevent zoom on form controls, r=masayuki

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9f7039ca819d

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Given that this isn't a new issue, I'm not convinced we need to worry about uplifting this fix to Beta for Fx72, but feel free to nominate if you feel otherwise.