Closed Bug 1557058 Opened 5 years ago Closed 5 years ago

use real data for protection report graph

Categories

(Firefox :: Protections UI, enhancement, P1)

Product:
Firefox
Component:
Protections UI
Version:
68 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

Details

(Whiteboard: [protection-report][triage])

Attachments

(1 file)

Bug 1557058 - use real data for protection report graph
47 bytes, text/x-phabricator-request
Details | Review

Once we have some data in the database and the graph has been built, we should populate the graph with real data.

Whiteboard: [protection-report][triage]
Blocks: 1559452
Priority: -- → P1
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93b614e367ac
use real data for protection report graph r=nhnt11,johannh

Backed out changeset 93b614e367ac (bug 1557058) for browser-chrome failures at browser/components/protections/test/browser/browser_protections_ui.js

Backout: https://hg.mozilla.org/integration/autoland/rev/468437eadc5a7e8f3ff30a79ff3b8490712b683d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=93b614e367acb0a08bdea00093e9a0c4022c4c0f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254827149&repo=autoland&lineNumber=2684

[task 2019-07-04T20:41:43.764Z] 20:41:43 INFO - TEST-START | browser/components/protections/test/browser/browser_protections_ui.js
[task 2019-07-04T20:41:45.985Z] 20:41:45 INFO - TEST-INFO | started process screentopng
[task 2019-07-04T20:41:47.074Z] 20:41:47 INFO - TEST-INFO | screentopng: exit 0
[task 2019-07-04T20:41:47.074Z] 20:41:47 INFO - Buffered messages logged at 20:41:43
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Entering test bound setup
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Leaving test bound setup
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Entering test bound test_graph_display
[task 2019-07-04T20:41:47.076Z] 20:41:47 INFO - Buffered messages finished
[task 2019-07-04T20:41:47.079Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | 7 bars have been found on the graph - 0 == 7 -
[task 2019-07-04T20:41:47.080Z] 20:41:47 INFO - Stack trace:
[task 2019-07-04T20:41:47.081Z] 20:41:47 INFO - resource://testing-common/content-task.js line 59 > eval:null:6
[task 2019-07-04T20:41:47.083Z] 20:41:47 INFO - resource://testing-common/content-task.js:null:60
[task 2019-07-04T20:41:47.084Z] 20:41:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T20:41:47.085Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Uncaught exception - TypeError: allBars[6] is undefined
[task 2019-07-04T20:41:47.088Z] 20:41:47 INFO - Leaving test bound test_graph_display
[task 2019-07-04T20:41:47.090Z] 20:41:47 INFO - GECKO(1511) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 110: uncaught exception: Object
[task 2019-07-04T20:41:47.091Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-07-04T20:41:47.093Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2019-07-04T20:41:47.093Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT | vsize 20974940MB | residentFast 1040MB
[task 2019-07-04T20:41:47.095Z] 20:41:47 INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_ui.js | took 2299ms
[task 2019-07-04T20:41:47.096Z] 20:41:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T20:41:47.100Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Found an unexpected tab at the end of test run: about:protections -
[task 2019-07-04T20:41:47.101Z] 20:41:47 INFO - checking window state
[task 2019-07-04T20:41:47.102Z] 20:41:47 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 110}]
[task 2019-07-04T20:41:48.221Z] 20:41:48 INFO - Console message: [JavaScript Error: "Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.221Z] 20:41:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 72}]
[task 2019-07-04T20:41:48.225Z] 20:41:48 INFO - GECKO(1511) | JavaScript error: resource://gre/modules/Sqlite.jsm, line 81: Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.227Z] 20:41:48 INFO - Console message: [JavaScript Error: "Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.228Z] 20:41:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 81}]
[task 2019-07-04T20:41:48.772Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1664
[task 2019-07-04T20:41:48.773Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1676
[task 2019-07-04T20:41:48.809Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1636
[task 2019-07-04T20:41:48.886Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1583
[task 2019-07-04T20:41:48.887Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1562
[task 2019-07-04T20:41:49.632Z] 20:41:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1511

Flags: needinfo?(ewright)

(In reply to Cristina Coroiu [:ccoroiu] from comment #3)

Backed out changeset 93b614e367ac (bug 1557058) for browser-chrome failures at browser/components/protections/test/browser/browser_protections_ui.js

Backout: https://hg.mozilla.org/integration/autoland/rev/468437eadc5a7e8f3ff30a79ff3b8490712b683d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=93b614e367acb0a08bdea00093e9a0c4022c4c0f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254827149&repo=autoland&lineNumber=2684

[task 2019-07-04T20:41:43.764Z] 20:41:43 INFO - TEST-START | browser/components/protections/test/browser/browser_protections_ui.js
[task 2019-07-04T20:41:45.985Z] 20:41:45 INFO - TEST-INFO | started process screentopng
[task 2019-07-04T20:41:47.074Z] 20:41:47 INFO - TEST-INFO | screentopng: exit 0
[task 2019-07-04T20:41:47.074Z] 20:41:47 INFO - Buffered messages logged at 20:41:43
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Entering test bound setup
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Leaving test bound setup
[task 2019-07-04T20:41:47.075Z] 20:41:47 INFO - Entering test bound test_graph_display
[task 2019-07-04T20:41:47.076Z] 20:41:47 INFO - Buffered messages finished
[task 2019-07-04T20:41:47.079Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | 7 bars have been found on the graph - 0 == 7 -
[task 2019-07-04T20:41:47.080Z] 20:41:47 INFO - Stack trace:
[task 2019-07-04T20:41:47.081Z] 20:41:47 INFO - resource://testing-common/content-task.js line 59 > eval:null:6
[task 2019-07-04T20:41:47.083Z] 20:41:47 INFO - resource://testing-common/content-task.js:null:60
[task 2019-07-04T20:41:47.084Z] 20:41:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T20:41:47.085Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Uncaught exception - TypeError: allBars[6] is undefined
[task 2019-07-04T20:41:47.088Z] 20:41:47 INFO - Leaving test bound test_graph_display
[task 2019-07-04T20:41:47.090Z] 20:41:47 INFO - GECKO(1511) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 110: uncaught exception: Object
[task 2019-07-04T20:41:47.091Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-07-04T20:41:47.093Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2019-07-04T20:41:47.093Z] 20:41:47 INFO - GECKO(1511) | MEMORY STAT | vsize 20974940MB | residentFast 1040MB
[task 2019-07-04T20:41:47.095Z] 20:41:47 INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_ui.js | took 2299ms
[task 2019-07-04T20:41:47.096Z] 20:41:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T20:41:47.100Z] 20:41:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Found an unexpected tab at the end of test run: about:protections -
[task 2019-07-04T20:41:47.101Z] 20:41:47 INFO - checking window state
[task 2019-07-04T20:41:47.102Z] 20:41:47 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 110}]
[task 2019-07-04T20:41:48.221Z] 20:41:48 INFO - Console message: [JavaScript Error: "Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.221Z] 20:41:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 72}]
[task 2019-07-04T20:41:48.225Z] 20:41:48 INFO - GECKO(1511) | JavaScript error: resource://gre/modules/Sqlite.jsm, line 81: Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.227Z] 20:41:48 INFO - Console message: [JavaScript Error: "Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T20:41:48.228Z] 20:41:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 81}]
[task 2019-07-04T20:41:48.772Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1664
[task 2019-07-04T20:41:48.773Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1676
[task 2019-07-04T20:41:48.809Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1636
[task 2019-07-04T20:41:48.886Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1583
[task 2019-07-04T20:41:48.887Z] 20:41:48 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1562
[task 2019-07-04T20:41:49.632Z] 20:41:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1511

thanks, on it.

Flags: needinfo?(ewright)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbb9a325576e
use real data for protection report graph r=nhnt11,johannh

Backed out changeset cbb9a325576e (bug 1557058) for browser-chrome failures at browser/components/protections/test/browser/browser_protections_ui.js

Backout: https://hg.mozilla.org/integration/autoland/rev/90203ccec5a623e6523de1afb82e2eea77d50668

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cbb9a325576ed78a813d8d535c6f8f8504aeccaa

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254843619&repo=autoland&lineNumber=2596

task 2019-07-04T23:08:44.101Z] 23:08:44 INFO - TEST-START | browser/components/protections/test/browser/browser_protections_ui.js
[task 2019-07-04T23:08:46.651Z] 23:08:46 INFO - TEST-INFO | started process screentopng
[task 2019-07-04T23:08:47.682Z] 23:08:47 INFO - TEST-INFO | screentopng: exit 0
[task 2019-07-04T23:08:47.684Z] 23:08:47 INFO - Buffered messages logged at 23:08:44
[task 2019-07-04T23:08:47.686Z] 23:08:47 INFO - Entering test bound setup
[task 2019-07-04T23:08:47.687Z] 23:08:47 INFO - Leaving test bound setup
[task 2019-07-04T23:08:47.689Z] 23:08:47 INFO - Entering test bound test_graph_display
[task 2019-07-04T23:08:47.690Z] 23:08:47 INFO - Buffered messages finished
[task 2019-07-04T23:08:47.691Z] 23:08:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | 7 bars have been found on the graph - 0 == 7 -
[task 2019-07-04T23:08:47.693Z] 23:08:47 INFO - Stack trace:
[task 2019-07-04T23:08:47.694Z] 23:08:47 INFO - resource://testing-common/content-task.js line 59 > eval:null:6
[task 2019-07-04T23:08:47.696Z] 23:08:47 INFO - resource://testing-common/content-task.js:null:60
[task 2019-07-04T23:08:47.697Z] 23:08:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T23:08:47.698Z] 23:08:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Uncaught exception - TypeError: allBars[6] is undefined
[task 2019-07-04T23:08:47.700Z] 23:08:47 INFO - Leaving test bound test_graph_display
[task 2019-07-04T23:08:47.701Z] 23:08:47 INFO - GECKO(1511) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-07-04T23:08:47.703Z] 23:08:47 INFO - GECKO(1511) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2019-07-04T23:08:47.705Z] 23:08:47 INFO - GECKO(1511) | MEMORY STAT | vsize 20974940MB | residentFast 1044MB
[task 2019-07-04T23:08:47.708Z] 23:08:47 INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_ui.js | took 2589ms
[task 2019-07-04T23:08:47.710Z] 23:08:47 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-04T23:08:47.711Z] 23:08:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_ui.js | Found an unexpected tab at the end of test run: about:protections -
[task 2019-07-04T23:08:47.715Z] 23:08:47 INFO - checking window state
[task 2019-07-04T23:08:47.717Z] 23:08:47 INFO - GECKO(1511) | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 110: uncaught exception: Object
[task 2019-07-04T23:08:47.719Z] 23:08:47 INFO - Console message: [JavaScript Error: "uncaught exception: Object" {file: "resource://testing-common/PromiseTestUtils.jsm" line: 110}]
[task 2019-07-04T23:08:48.828Z] 23:08:48 INFO - Console message: [JavaScript Error: "Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T23:08:48.829Z] 23:08:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 72}]
[task 2019-07-04T23:08:48.837Z] 23:08:48 INFO - GECKO(1511) | JavaScript error: resource://gre/modules/Sqlite.jsm, line 81: Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T23:08:48.837Z] 23:08:48 INFO - Console message: [JavaScript Error: "Error: Warning: Sqlite connection 'protections.sqlite#1' was not properly closed. Auto-close triggered by garbage collection.
[task 2019-07-04T23:08:48.838Z] 23:08:48 INFO - " {file: "resource://gre/modules/Sqlite.jsm" line: 81}]
[task 2019-07-04T23:08:49.349Z] 23:08:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1662
[task 2019-07-04T23:08:49.350Z] 23:08:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1671
[task 2019-07-04T23:08:49.391Z] 23:08:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1634
[task 2019-07-04T23:08:49.467Z] 23:08:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1562
[task 2019-07-04T23:08:49.515Z] 23:08:49 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1583
[task 2019-07-04T23:08:50.211Z] 23:08:50 INFO - GECKO(1511) | Completed ShutdownLeaks collections in process 1511

Flags: needinfo?(ewright)

I am sorry, a bit unrelated question.
Will such things like Facebook Pixel or Google Analytics be blocked by this functionality as well?

(In reply to Maxim from comment #8)

I am sorry, a bit unrelated question.
Will such things like Facebook Pixel or Google Analytics be blocked by this functionality as well?

This particular feature is about collecting counts of the type (cookies, trackers, fingerprinters etc) of the things being blocked and displaying that data to the user.
The things that are blocked depend on what type of restrictions the user has set, and what is on the block lists, so I can't directly answer that question. I'm trying to think of where to point you to to find out more info, perhaps in the #security channel on IRC.

Flags: needinfo?(ewright)

I am not seeing the same failure on my pushes to try, I'll try landing this again shortly.

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68c6aa2ceea6
use real data for protection report graph r=johannh
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d050bd93ea39
use real data for protection report graph r=johannh
Flags: needinfo?(ewright)

So sorry for all the backouts, I've been careless. Here's a new try run, I'll try landing again once it passes https://treeherder.mozilla.org/#/jobs?repo=try&revision=d59136cfb4387b35bb72b1981b4a4e47e8e434d2&selectedJob=255803971

Flags: needinfo?(ewright)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ca194504eb2
use real data for protection report graph r=johannh

https://hg.mozilla.org/mozilla-central/rev/7ca194504eb2

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: