remove grid usage from comm/mailnews/addrbook/prefs/content/pref-directory-add.xul
Categories
(Thunderbird :: Address Book, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(4 files, 8 obsolete files)
Run window.openDialog("chrome://messenger/content/addressbook/pref-directory-add.xul", "", "chrome,modal,resizable=no,centerscreen", null) to open the dialogue box.
Comment 1•5 years ago
|
||
Available from Preferences | Composition | Edit Directories... | Add
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #3)
I think we need to figure out classes for the inline styles instead.
Should I create the util CSS file for grid usage and import it wherever we are using?
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
•
|
||
Comment 8•5 years ago
|
||
Some alignment issues on Linux
Assignee | ||
Comment 9•5 years ago
|
||
So currently we have three approaches:
- hbox and vbox
- html:div
- html:table
If the layout is very simple and doesn't have multiple elements i.e. we just have a column with the same elements, I use hbox and vbox. If suppose column has textbox and menlist in it, it will have alignment issues in terms of rows.
If the layout is small but has columns with different elements like textbox, button, menulist, etc. I try to use html:div. But width property is not so adjustable here. So we will have some width related issue like all labels should occupy width same as a label with a maximum width. But here, labels generally occupy width up to some percentage of the full width like 30% which is generally more than the label with the maximum width. In such cases, I use html:tabel.
Assignee | ||
Comment 10•5 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #8)
Some alignment issues on Linux
I find this alignment issue on the trunk also and it is due to our usage of html:input. Currently, I will solve it with inline styling. We can take care of this thing when we convert all textbox to html:input.
Assignee | ||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
(In reply to Khushil Mistry [:khushil324] from comment #9)
So currently we have three approaches:
3) html:table
Should only use table for cases where the data is semantically tabular. It should not be used for layout.
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
the 5px comes from the input/textbox different styling - I'd leave that "bug" in and let the remaining textbox conversion take care (automatcially).
I'm not sure if hbox/vbox or div is better. On one hand, html conversion will happen likely before next ESR, but that there is things like <xul:spacer flex="1"/> in there makes it kind of just a hack...
Assignee | ||
Comment 16•5 years ago
|
||
Comment 17•5 years ago
|
||
Assignee | ||
Comment 18•5 years ago
|
||
I have added empty <div/> and it worked.
Comment 19•5 years ago
|
||
Assignee | ||
Comment 20•5 years ago
|
||
Can you (In reply to Magnus Melin [:mkmelin] from comment #19)
this button is not vertically centred anymore
Can you attach a SS for this as I am not able to see this issue on Mac.
Comment 21•5 years ago
|
||
Screenshot
Assignee | ||
Comment 22•5 years ago
|
||
Were you able to see this problem when the usage of <spacer> was there?
Comment 23•5 years ago
|
||
Yes it is the same
Assignee | ||
Comment 24•5 years ago
|
||
Comment 25•5 years ago
|
||
Assignee | ||
Comment 26•5 years ago
|
||
Verified on Linux Machine.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 27•5 years ago
|
||
Comment 28•5 years ago
|
||
Assignee | ||
Comment 29•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 30•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0e4007423df0
remove grid usage from pref-directory-add.xul. r=mkmelin
Updated•5 years ago
|
Description
•