1557244 - Service worker registrations should not be resurrected after being unregistered

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Jake Archibald]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Steps to reproduce:

As agreed at TPAC 2018.

Spec change https://github.com/w3c/ServiceWorker/pull/1415
Tests https://github.com/web-platform-tests/wpt/pull/17139

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Thanks for filing the bug! This is something we plan to do in the near term.

Comment 3

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1557244 - Disallow resurrection of unregistered ServiceWorkerRegistrations r=asuth

• Remove ServiceWorkerRegistrations' pending uninstall flag.

• Rename ServiceWorkerRegistrationListener's RegistrationRemoved method to
  RegistrationCleared; registrations are no longer necessarily consider
  invalid when they are removed from the "scope to registration map", but rather
  when they're both removed from the map and not controlling clients (at which
  point Clear is called).

• Maintain the invariant that no ServiceWorkerRegistrationInfo in
  ServiceWorkerManager::RegistrationDataPerPrincipal::mInfos (i.e. the "scope
  to registration map") is in the unregistered state. Assertions check this in
  ServiceWorkerManager::AddScopeAndRegistration and
  ServiceWorkerRegistrationInfo::SetUnregistered.

• Fix some incorrect web platform tests.

Comment 4

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1557244 - Inherit controllers for blob URL workers in child-intercept mode r=asuth

Depends on D38684

Comment 5

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1557244 - Inherit controllers in parent-intercept mode r=asuth

Depends on D38685

Comment 6

[Perry Jiang [:perry] [no longer employee, use ni?]]

Attachment: Bug 1557244 - Remove `waitForControlled(win)` testing utility r=asuth

postMessage('claim') followed by waitForControlled(win) was used instead of
calling clients.claim() in a Service Worker's activate event handler; this
invocation of the event handler was not reliable due to resurrection
(resurrected active workers won't receive an activate event). This is no
longer necessary with resurrection removed.

Depends on D38686

Comment 7

[Perry Jiang [:perry] [no longer employee, use ni?]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd124a9e1868667a69de87882f73d68feacde128

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c64a2a56070e
Disallow resurrection of unregistered ServiceWorkerRegistrations r=asuth
https://hg.mozilla.org/integration/autoland/rev/7509af276a01
Inherit controllers for blob URL workers in child-intercept mode r=asuth
https://hg.mozilla.org/integration/autoland/rev/5d821918d5c5
Inherit controllers in parent-intercept mode r=asuth
https://hg.mozilla.org/integration/autoland/rev/d8bcac69e89b
Remove `waitForControlled(win)` testing utility r=asuth

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18117 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c64a2a56070e
https://hg.mozilla.org/mozilla-central/rev/7509af276a01
https://hg.mozilla.org/mozilla-central/rev/5d821918d5c5
https://hg.mozilla.org/mozilla-central/rev/d8bcac69e89b

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged