Closed Bug 1557286 Opened 2 years ago Closed 2 years ago

shouldn't show any context from ancestor if the input field contextmenu is shown

Categories

(Toolkit :: General, task)

Product:
Toolkit
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

Bug 1557286 - should preventDefault the event after showing an input field contextmenu to avoid other context menus showing. r=gijs
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

+++ This bug was initially created as a clone of Bug #1531155 +++

Working on bug 1556839 I found that after adding code to get the address book search input context to work, we get both that context menu and the input field context menu showing up (which is set for the toolbar in which the search input is located).

Once we get the popup, that event should not be allowed to bubble up.

Blocks: 1556839
Summary: shouldn't bubble the event after showing an input field contextmenu → shouldn't show any context from ancestor if the input field contextmenu is shown

Try looks ok to me.

Attachment #9070222 - Attachment description: Bug 1557286 - shouldn't bubble the event after showing an input field contextmenu. r=surkov → Bug 1557286 - should preventDefault the event after showing an input field contextmenu to avoid other context menus showing. r=gijs
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/integration/autoland/rev/23f8cd8cfdfb
should preventDefault the event after showing an input field contextmenu to avoid other context menus showing. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/23f8cd8cfdfb

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9070222 [details]
Bug 1557286 - should preventDefault the event after showing an input field contextmenu to avoid other context menus showing. r=gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Some Thunderbird input fields showing a wrong context menu. Maybe add-ons also affected.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just adding a preventDefault() in JS code after popup was shown.
  • String changes made/needed: None
Attachment #9070222 - Flags: approval-mozilla-beta?

Comment on attachment 9070222 [details]
Bug 1557286 - should preventDefault the event after showing an input field contextmenu to avoid other context menus showing. r=gijs

approved for 68.0b9

Attachment #9070222 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.