1556839 - Searchbox in Addressbook has wrong context menu

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Richard Marti (:Paenglab)]

The Addressbook searchbox shows the toolbar context menu instead of the edit menu like all other boxes show.

Comment 1

[Jorg K (CEST = GMT+2)]

Also broken in TB 68 beta. Most likely a de-XBL issue. Magnus, can you please get a de-XBL person to have a look.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1556839_absearch_context.patch

I think this is the c-c fix, and a e.preventDefault(); should be added at https://searchfox.org/comm-central/rev/4a11fb532256bbd0901758d25ec6a79fb2d87afd/mozilla/toolkit/content/editMenuOverlay.js#94 (or both context menus show up). I'll file a bug for m-c.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070217 [details] [diff] [review]
bug1556839_absearch_context.patch

Richard suggested this (via a PM) for bug 1556582, but he wanted to avoid a double menu. Maybe we should wait until bug 1557286 is fixed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/62dc416dcabf
Restore context menu in searchbox in address book that got lost in bug 1532595. r=jorgk DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/dd02d715b4e81b38a3ae9da4eaefbc48805a9b2a