1557854 - Remove unused get/setColorMatrix bits on docshell

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect, P2)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1557854. Remove unused get/setColorMatrix bits on docshell. r=eeejay

Comment 2

[Neha Kochar [:neha]]

Boris, this bug has a patch about a month old. Should we ping the reviewer or have someone else review?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Eitan's bugzilla name says he's gone until "mid/late June", and he currently has needinfo requests blocked, so it sounds like he's not back yet?

This isn't really urgent yet, so I wasn't worrying about it too much. The original commit to add these methods was reviewed by smaug, but I was trying to avoid dumping more reviews on his plate.

Comment 4

[Eitan Isaacson [:eeejay]]

Hi Boris.

It looks like we have a devtools feature we are looking into that might take advantage of this.

Maliha our intern can elaborate. I guess it is worth holding off on removing this.

Comment 5

[Maliha Islam [:mislam]]

Hello,
I am currently working on Bug 1564966 that will add a feature in the devtools accessibility panel to simulate different types of color blindness. This requires applying a color matrix filter to the entire document and so, the get/setColorMatrix methods on docshell would definitely come handy!

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK, not a problem. I filed bug 1566543 on the thing we should do instead, then.