Landed patch not "published" in phabricator
Categories
(Conduit :: Phabricator, defect)
Tracking
(Not tracked)
People
(Reporter: apavel, Unassigned)
Details
For bug 1540635 the mgmt bot mentioned that there is a patch with review+ that hasn't landed yet:
https://bugzilla.mozilla.org/show_bug.cgi?id=1540635#c17
However, the patch got landed in a previous comment https://bugzilla.mozilla.org/show_bug.cgi?id=1540635#c12
Initially, the patch got landed via lando and then the changes got backed out.
After fixing what was causing the issue, the changes got relanded (manually it appears, not via lando) in comment 12.
when it was relanded (https://hg.mozilla.org/integration/autoland/rev/e2cca2f460bc) the commit description didn't contain a reference to the revision.
initial landing:
Bug 1540635 - Fuzzy-if 1295466-1.xhtml on linux for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D29451
second landing:
Bug 1540635 - Fuzzy-if 1295466-1.xhtml on linux for frequent failures. r=jmaher
with no link to the revision there's no way for phabricator to automatically close it.
code should be landed with lando, or the Differential Revision line should be added/left intact if landing manually.
|
Reporter | |
Comment 2•6 years ago
|
||
Hi Byron.
Could you take a look at https://bugzilla.mozilla.org/show_bug.cgi?id=1485762#c10 and Alex's comment?
From the conversation I understand that this is a different case. The patch was landed from phabricator (https://hg.mozilla.org/integration/autoland/rev/d846803d6d6e) but then backed out.
Please file new bugs for new issues rather than needinfo'ing on an existing resolved bug.
That revision was reopened as a result of the fix for bug 1549693. Revisions that were reopened as a result of a backout from an uplift-required repo will need to be manually closed if relevant (ref: bug 1554363 comment 3)
Description
•