1558417 - Have an onboarding UI for editor mode

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

When using the Console to edit multiple lines and have not used, I want to be informed about multiline mode if I haven’t use it yet

Could also be used in this case:

When pasting long text, I want the input to switch to multiline mode, so that I can properly edit.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1558417 - Add onboarding UI for Editor. r=Honza.

The onboarding UI is displayed on top of the Editor.
A dismiss button hides it forever (this is handled via
a pref that is set to false when clicking the button).

We take this as an opportunity to polish the Editor UI/wording
a bit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa911cc3fcf
Add onboarding UI for Editor. r=Honza.

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/230fc45161d8
Backed out changeset 9aa911cc3fcf for failing at browser_jsterm_editor_toolbar.js on a CLOSED TREE.

Comment 4

[Raul Gurzau (:RaulG)]

Backed out changeset 9aa911cc3fcf (bug 1558417) for failing at browser_jsterm_editor_toolbar.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/230fc45161d843f990b2d58de509ea2e45bf2ce3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&failure_classification_id=2&revision=9aa911cc3fcf58e031540b5161f3f4032ce9567a&selectedJob=263860844

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=263860844&repo=autoland&lineNumber=1626

Log snippet:
[task 2019-08-28T13:13:13.824Z] 13:13:13 INFO - TEST-START | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js
[task 2019-08-28T13:13:18.237Z] 13:13:18 INFO - TEST-INFO | started process screenshot
[task 2019-08-28T13:13:18.438Z] 13:13:18 INFO - TEST-INFO | screenshot: exit 0
[task 2019-08-28T13:13:18.438Z] 13:13:18 INFO - Buffered messages logged at 13:13:13
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - Entering test bound
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - Adding a new tab with URL: data:text/html;charset=utf8,<p>Test editor toolbar
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - Tab added and finished loading
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - Buffered messages logged at 13:13:15
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - Test that the toolbar is not displayed when in editor mode
[task 2019-08-28T13:13:18.439Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The toolbar isn't displayed when not in editor mode -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - Buffered messages logged at 13:13:17
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - Test that the toolbar is displayed when in editor mode
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The toolbar is displayed when in editor mode -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - Test that the toolbar has the expected items
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The button has the expected text -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The Run Button has the correct title -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - Test that clicking on the Run button works as expected
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The expression and its result are displayed in the output -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | input is still focused after clicking the Run button -
[task 2019-08-28T13:13:18.440Z] 13:13:18 INFO - Buffered messages logged at 13:13:18
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The expression and its result are displayed in the output -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | input is still focused after clicking the Run button -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - Test that clicking the previous expression button works as expected
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The Previous Expression Button has the correct title -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The JS Terminal Editor has the correct previous expresion ${"area" + 51} = aliens? -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The JS Terminal Editor has the correct previous expresion ${1 + 1} = 2 -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - Test that clicking the next expression button works as expected
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The Next Expression Button has the correct title -
[task 2019-08-28T13:13:18.441Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | The JS Terminal Editor has the correct next expresion ${"area" + 51} = aliens? -
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | undefined assertion name -
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - Test that clicking the close button works as expected
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - Buffered messages finished
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js | Close button has expected title - Got Switch back to inline mode (Ctrl + B), expected Close Editor (Ctrl + B)
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - Stack trace:
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - chrome://mochikit/content/browser-test.js:test_is:1595
[task 2019-08-28T13:13:18.442Z] 13:13:18 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_jsterm_editor_toolbar.js:null:108

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I did the test fix locally, and then didn't updated the phabricator patch before landing 🤦‍♂️

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1763c1b86c09
Add onboarding UI for Editor. r=Honza.

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1763c1b86c09