1558452 - Richlistbox headers missaligned when scrollbar is shown on windows

Status: REOPENED

(Firefox :: Settings UI, defect, P3)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: left-instead-right.png

[Affected versions]:
Fx 69.0a1 (20190610214846)

[Affected platforms]:
Windows 10 x64
Ubuntu 18.04 x64
Mac OS X 10.14

[Steps to reproduce]:

1. Open Firefox.
2. Go to in about:config to turn on the "Block autoplay" feature, set media.autoplay.default = 1 (block)
   media.autoplay.enabled.user-gestures-needed = true
   preferences.
3. Access some websites: https://edition.cnn.com/, https://www.arcticmonkeys.com/ in order to add them to a list from "Settings - Autoplay" page list (sitePermissions panel on a page).
4. In address bar click on site information icon, at the bottom of this pop up at Permission section you will see "Autoplay sound" icon with "Block Audio" status button.
5. Change the status to "Allow Audio and Video".
6. Click on settings gear button, then on "Settings..." button from Autoplay.
   At this step https://edition.cnn.com/, https://www.arcticmonkeys.com/ websites added to the list with "Allow Audio and Video" status.

[Expected result]:
The "Allow Audio and Video" status button is right aligned.

[Actual result]:
The "Allow Audio and Video" status button is left aligned instead of right aligned.

[Additional Information]:
Please observe the attached screenshot for more details.

Comment 1

[Johann Hofmann [:johannh]]

Dale, do you want to triage this?

Comment 2

[:Gijs (he/him)]

Is this a regression?

Why was it removed from the QA tracking bug?

Comment 3

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I removed from 1557002 bug because this is not related to "Block Autoplay" feature. This is not a regression because the issue has just introduced with the feature "Block Autoplay" last week.

Comment 4

[:Gijs (he/him)]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #3)

I removed from 1557002 bug because this is not related to "Block Autoplay" feature. This is not a regression because the issue has just introduced with the feature "Block Autoplay" last week.

This seems to say it's both introduced by "block autoplay" and "not related" to the same? That doesn't make much sense to me... Which is it?

Comment 5

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Sorry for misunderstanding, this issue seems to be introduced with bug: 1543812 (when this feature was intruduced in nightly), finally it seems to be a "Block Autoplay" feature bug.

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Bug 1558452 - Fix sitePermission column header width. r?johannh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c09f4d18f8a
Fix sitePermission column header width. r=johannh

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9c09f4d18f8a

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

This issue has been fixed only when the scroll does not appear in the exception list (see: exception-list-without-scroll.png). In case if appear the scroll bar in the exception list, the issue is still there (see: exception-list-with-scroll.png)

Comment 10

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: exception-list-with-scroll.png

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: exception-list-without-scroll.png

Comment 12

[Dale Harvey (:daleharvey)]

I think you posted the same screenshot here? neither of those look like they scroll. I added enough exceptions to make this panel scroll but dont see any bugs here

Comment 13

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: exception-list-with-scroll-new.png

Comment 14

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Sorry for the inconvenience, here is the right screenshot: exception-list-with-scroll-new.png

Comment 15

[Dale Harvey (:daleharvey)]

Ah ok thank you, didnt account for the extra space taken up by windows scrollbars here, lets nudge this a little more

Comment 16

[Dale Harvey (:daleharvey)]

Attachment: Bug 1558452 - Allow enough space for windows scrollbar. r?Paolo

Comment 17

[:Paolo Amadini]

Attachment: D36213-Applied.png

I used Developer Tools to remove the min-height on the dialog and on the richlistbox, and the issue seems to persist with the patch applied. I'm not sure what can be done here, since the layout of the header and the list body are independent, now that we removed support for list headers from richlistbox. Maybe worth filing a separate bug.

Comment 18

[Dale Harvey (:daleharvey)]

Hrm you are right, I tested by updating the headers but didnt check updating all the menuitems, I didnt think the scrollbar width would be taken into account

So yeh this happens with the rest of the richlistbox's (popup windows + install addon exceptions in about:preferences#privacy) however their problems are less visible because their values are plain text boxes without a background, the menulist background makes this very visible

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1562234, cheers

Comment 19

[Dale Harvey (:daleharvey)]

Updating the title and clarifying the issue + deassigning because this is probably going to need work in the component

When viewing the exceptions panels @ about:preferences#privacy, if there is enough exceptions to cause a scrollbar on windows the contents are misaligned with the headers because the scrollbars width is taken into account laying out the contents (but not the headers), this is most visible in the Autoplay -> Settings list due to the combobox being used

Comment 20

[:Gijs (he/him)]

Victor, is this something you could help with, given you've worked on de-XBL-ing <tree> etc.?

Comment 21

[Victor Porof [:vporof][:vp]]

My hands are completely full for this and next week, but I'll try to take a look afterwards if there's no progress.

Keeping ni.

Comment 22

[Andrew Swan [:aswan]]

Is the idea here to teach <listheader> to adjust itself when scrollbars appear in a neighboring <richlistbox>? If that's the plan, is there any point in having both this bug and bug 1562234?

Comment 24

[Victor Porof [:vporof][:vp]]

Is this still an issue? I suspect this might've been fixed by bug 1532863 or a similar one by :bgrins (can't find the bug no. atm).

Comment 25

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Yes this is still an issue, reproduced on Fx 71.0b11.

Comment 26

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,
I've tested this using the latest Nightly version 74.0a1 (2020-01-13) (64-bit) for Ubuntu 18.04.3 LTS and I’m able to reproduce the issue. Based on this I will mark firefox74 flag as affected. I can reproduce A, B and C from the description.
Best,
Clara

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 28

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch but I'm marking the bug fix-optional to remove it from new regression triage.