1558484 - [3rd party] Add ability to log users in using GitHub

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Matjaz Horvat [:mathjazz]]

The Rust instance of Pontoon authenticates users via GitHub. We should take their patches (1, 2) upstream.

We'd then have 3 authentication systems:

• Firefox Accounts
• GitHub
• Django (login only, user creation only possible via Django admin)

We should also replace the DJANGO_LOGIN setting with something like AUTHENTICATION_METHOD and make "django" the default value.

Comment 1

[Anand]

:mathjazz would you be open to including any other popular providers, too? I'm thinking in particular of Google (while I don't love that option, I think for many prospective translators it would be a lot friendlier than GitHub)

Comment 2

[Matjaz Horvat [:mathjazz]]

(In reply to Anand from comment #1)

:mathjazz would you be open to including any other popular providers, too? I'm thinking in particular of Google (while I don't love that option, I think for many prospective translators it would be a lot friendlier than GitHub)

We're open to adding more providers, including Google. Since we don't need it at Mozilla ATM, it would be a P5 bug, though:
https://wiki.mozilla.org/L10n:Pontoon#Prioritizing_bugs

Comment 3

[Axel Hecht [:Pike]]

skade has two commits on the rust-lang fork for gh auth, https://github.com/rust-lang/pontoon/commit/918e0007c9fedd1abecfc522a9cf627418bd6c9c and https://github.com/rust-lang/pontoon/commit/ffd97d95633b26eee2eacbc886f5d15dc8d0aa00.

Comment 4

[Matjaz Horvat [:mathjazz]]

Hi Antonio, we have lots of request to work on Mentored bugs from Outreachy participants.

In case you're not actively working on this, would you be OK if I make it available to other contributors?

Comment 5

[Antonio Ladeia]

Hello Matjaz, I want to work on this task, but I need some help. I have some problem with IRC client (my clients disconect when I do offline). tomorrow I will try contact with you in irc.

Comment 6

[Matjaz Horvat [:mathjazz]]

Hi Antonio,

Let's continue here until you solve the issue with the IRC client. Note that we also "bridge" the IRC channel to Telegram:
https://t.me/pontoon

For starters, you can put the code directly into pontoon/settings/base.py. We can move it to some other place if that turns out to be necessary.

Comment 7

[Matjaz Horvat [:mathjazz]]

I've updated the Description: let's make "django" the default AUTHENTICATION_METHOD instead of "fxa".

Some users are having trouble making FxA to work locally. And those who actually make it work often end up creating a separate account from the one created make setup, which means they aren't logged in as superusers.

Comment 8

[Matjaz Horvat [:mathjazz]]

Assigning to abowler2 since this became more urgent and I can no longer get in touch with Antonio.

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1442

Comment 10

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/30d8c3d3dd0630d79dce8a75208f9778d6218864

Comment 11

[Alan.V]

(In reply to Matjaz Horvat [:mathjazz] from comment #2)

(In reply to Anand from comment #1)

:mathjazz would you be open to including any other popular providers, too? I'm thinking in particular of Google (while I don't love that option, I think for many prospective translators it would be a lot friendlier than GitHub)

We're open to adding more providers, including Google. Since we don't need it at Mozilla ATM, it would be a P5 bug, though:
https://wiki.mozilla.org/L10n:Pontoon#Prioritizing_bugs

Hey, can you please add OpenID (Steam) support?

We are game developers and for users it would be more convenient for users to use steam and not github

Thank you!

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Alan.V from comment #11)

Hey, can you please add OpenID (Steam) support?

We are game developers and for users it would be more convenient for users to use steam and not github

Thank you!

Please don't add requests to an existing (and fixed) bug. Feel free to file a new bug, and patches are welcome.