1558903 - Ad server handle multiple shims being passed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Scott [:thecount] Downe]

Right now in bug 1550119 we send back a single shim.

We want to update this to send multiple shims, depending on the event.

The data from the story would look like:

shim: {
  "click": "",
  "impression: :""
},

And when we send the event, we need to ensure we send the right shim.

the event data itself should not need to change, sending only 1 shim still.

Comment 1

[Jessilyn Davis]

Ideally: get this landed by EOW (6/14) for QA next week.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5106

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 4

[Scott [:thecount] Downe]

To test:

1. Clone this repo locally https://github.com/ScottDowne/test-data

2. Run npm install

3. Run node start.js

4. Set this pref browser.newtabpage.activity-stream.discoverystream.endpoints to "https,http"

5. Set this pref browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/1a08ca9f15ceb4ea0aafb9532e5d1381/raw/eef821bf4f40594d3c12ea684df3bdef8508a84e/adzerk-layout-2"}

6. Ensure you can see telemetry events

7. Open a new tab, you should see a layout of weird cards, heros, and lists.

8. You should see 6 spocs total.

9. Open your browser toolbox (tools -> web developer -> browser toolbox)

10. Ensure click and view ping events have the shim prop being passes in for spocs, and not for regular cards. The shim prop might look close to this:

"shim": "spoc shim 6 click"

The numbers in there might change depending on which spoc you clicked on.

Comment 5

[Scott [:thecount] Downe]

Attachment: GitHub Pull Request

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/0dff9f803849

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that separate shims are sent based on the event (impression, click, save, and delete) on the latest Nightly 69.0a1 (Build ID 20190618214619) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.