Send spoc shim to the SPOC telemetry calls
Categories
(Firefox :: New Tab Page, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | verified |
People
(Reporter: thecount, Assigned: thecount)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
In addition to existing telemetry, we will also send SPOC-specific impression/viewable/click events to the Pocket Proxy. These events will also need to have the shim appended. For the shim work, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1550118
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 1•6 years ago
|
||
A change to this ticket (which might suggest we file a new ticket -or- rename).
We are no longer going to fire SPOC-specific telemetry directly to the Pocket Proxy.
Instead, we will rely on the existing telemetry pipeline and rely on our telemetry infrastructure in Google Cloud to deliver the SPOC-specific events.
The only change needed in the Firefox client is to update the SPOC telemetry calls to include the "shim" value that will be included with each SPOC.
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 6•6 years ago
|
||
Hi Kenny,
Reviewing.....
Comment 7•6 years ago
|
||
Trust data review = r+.
The basic properties of the new tab collection are still being maintained even with the addition of the the shim. While this could hypothetically leak web activity we have a set of mitigations in place (only associated with the Pocket ID and not client_id and only the ad that was clicked with no information on the triggering parameters). Ok as part of the default on Cat 2 data.
Updated•6 years ago
|
Assignee | ||
Comment 8•6 years ago
|
||
To test:
- Set this pref
browser.newtabpage.activity-stream.discoverystream.endpoints
to "https,http" - Set this pref
browser.newtabpage.activity-stream.discoverystream.config
to{"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/b85c57830405db12a18222ca62b4a3f6/raw/8febea501f10ad43aa2ca9f90b531bdd40136127/adzerk-layout"}
- Ensure you can see telemetry events
- Open a new tab, you should see a layout of weird cards, heros, and lists.
- You should see 6 spocs total.
- Open your jsdebugger
- Ensure click and view ping events have the shim prop being passes in for spocs, and not for regular cards.
Comment 9•6 years ago
|
||
It looks like the github counterpart was merged 4 days ago. @Scott, was this merged into Nightly as well? Or is it waiting for an export?
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Updated steps to test because these old ones relied on a GET request which is now a POST request as of bug 1550115
New steps to test:
-
Clone this repo locally https://github.com/ScottDowne/test-data
-
Run npm install
-
Run node start.js
-
Set this pref
browser.newtabpage.activity-stream.discoverystream.endpoints
to "https,http" -
Set this pref
browser.newtabpage.activity-stream.discoverystream.config
to{"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/ScottDowne/1a08ca9f15ceb4ea0aafb9532e5d1381/raw/eef821bf4f40594d3c12ea684df3bdef8508a84e/adzerk-layout-2"}
-
Ensure you can see telemetry events
-
Open a new tab, you should see a layout of weird cards, heros, and lists.
-
You should see 6 spocs total.
-
Open your jsdebugger
-
Ensure click and view ping events have the shim prop being passes in for spocs, and not for regular cards. The shim prop might look close to this:
"shim":{"click":"spoc shim 6 click","impression":"spoc shim 6 impression","delete":"spoc shim 6 delete","save":"spoc shim 6 save"}
or
"shim": "spoc shim 6 click"
The numbers in there might change depending on which spoc you clicked on, and if it was a click or a view. You might also see all the data if 1558903 has not landed yet.
Comment 13•6 years ago
|
||
Marking this issue as verified as a part of bug 1558905 and bug 1558903.
Updated•6 years ago
|
Comment 14•6 years ago
|
||
Description
•