LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error
Categories
(Core :: Storage: localStorage & sessionStorage, defect, P1)
Tracking
()
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Bug 1558112 tried to fix this, but without the rollback. The rollback is needed, because the shadow database can't be detached if the transaction is still active.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6baa1883dc72 LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
Comment 3•5 years ago
|
||
Backed out for ES Lint failure.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251572490&repo=mozilla-inbound&lineNumber=221
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a91efd693851d156f5680c88e6f91d12406ec3fe
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62f14c80b305 LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
Comment 5•5 years ago
|
||
bugherder |
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: LocalStorage shutdown hangs have been greatly reduced after the patch landed on Nightly. We want to improve situation on beta and eventually release too.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch landed only yesterday, but it would be really good to test this on beta ASAP. It can improve our reputation in regards of application quit (infamous shutdown hangs).
We have many tests for LocalStorage already and this patch adds a new one that simulates a condition that was causing a LocalStorage shutdown hang. - String changes made/needed: None
Comment 7•5 years ago
|
||
Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
more localstorage shutdownhang work, approved for 68.0b11
Comment 8•5 years ago
|
||
bugherder uplift |
Description
•