LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error

RESOLVED FIXED in Firefox 68

Status

()

defect
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: janv, Assigned: janv)

Tracking

(Blocks 2 bugs)

Trunk
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed, firefox69 fixed)

Details

Attachments

(1 attachment)

Bug 1558112 tried to fix this, but without the rollback. The rollback is needed, because the shadow database can't be detached if the transaction is still active.

Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6baa1883dc72
LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f14c80b305
LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

Beta/Release Uplift Approval Request

  • User impact if declined: LocalStorage shutdown hangs have been greatly reduced after the patch landed on Nightly. We want to improve situation on beta and eventually release too.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch landed only yesterday, but it would be really good to test this on beta ASAP. It can improve our reputation in regards of application quit (infamous shutdown hangs).
    We have many tests for LocalStorage already and this patch adds a new one that simulates a condition that was causing a LocalStorage shutdown hang.
  • String changes made/needed: None
Flags: needinfo?(jvarga)
Attachment #9071782 - Flags: approval-mozilla-beta?

Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

more localstorage shutdownhang work, approved for 68.0b11

Attachment #9071782 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.