1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P1)

Description

[Jan Varga [:janv]]

Bug 1558112 tried to fix this, but without the rollback. The rollback is needed, because the shadow database can't be detached if the transaction is still active.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6baa1883dc72
LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

Comment 3

[Razvan Maries]

Backed out for ES Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6baa1883dc7242a30116e2eb7467e48b20135cca&selectedJob=251572490&searchStr=linting%2Copt%2Csource-test-mozlint-eslint%2C%28es%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251572490&repo=mozilla-inbound&lineNumber=221

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a91efd693851d156f5680c88e6f91d12406ec3fe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f14c80b305
LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/62f14c80b305

Comment 6

[Jan Varga [:janv]]

Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: LocalStorage shutdown hangs have been greatly reduced after the patch landed on Nightly. We want to improve situation on beta and eventually release too.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch landed only yesterday, but it would be really good to test this on beta ASAP. It can improve our reputation in regards of application quit (infamous shutdown hangs).
  We have many tests for LocalStorage already and this patch adds a new one that simulates a condition that was causing a LocalStorage shutdown hang.
• String changes made/needed: None

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9071782 [details]
Bug 1559029 - LSNG: Connection::FlushOp::DoDatastoreWork needs to automatically rollback the transaction and detach the shadow database on an error; r=asuth

more localstorage shutdownhang work, approved for 68.0b11

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/192625555364