Closed Bug 1559176 Opened 1 year ago Closed 1 year ago

Make the Account Central use the dark theme when when 'prefers-color-scheme: dark' is set

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

prefers-color-scheme: dark is on Mac and Windows automatically enabled. When you use the dark system theme TB could also show some pages in a dark mode.

This bug is to enable this functionality for the Account Central

This is the second bug for making a page dark.

I unified some code in the shared accountCentral.css. This changes some things on Mac to be in sync with the other two platforms.
For example I scaled the Mac icons to 24px like on the other two platforms.

I think we should exchange the icons to new SVG ones. What do you think, would you create them? I'd file then a follow-up bug for the icon work. It would be great if we could do this before we release TB 68.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9071937 - Flags: review?(alessandro)
Comment on attachment 9071937 [details] [diff] [review]
1559176-dark-accountCentral.patch

Review of attachment 9071937 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, now it properly adapts to the dark mode.
r+

I do agree regarding the exchange of the icons for new SVG.
Feel free to create the follow up bug and assign it to me so I can start creating those that don't come available with our Photon icons system.
Attachment #9071937 - Flags: review?(alessandro) → review+
Keywords: checkin-needed
Attachment #9071937 - Flags: approval-comm-beta?
Depends on: 1559867

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ab5f92797df2
Make the Account Central use the dark theme when when 'prefers-color-scheme: dark' is set. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
Attachment #9071937 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.