1559205 - Add support for moz-proxy to LoginHelper.getLoginOrigin

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

moz-proxy scheme isn't currently supported by LoginHelper.getLoginOrigin because calling displayHostPort on a moz-proxy nsURI throws an exception.

Comment 1

[Sergey Galich [:serg]]

Attachment: Bug 1559205, 1611093, 1748828 - support moz-proxy in about:logins r=dimi!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d76fcef4378
1611093, 1748828 - support moz-proxy in about:logins r=dimi

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0d76fcef4378

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This potentially interesting for the enterprise environment. What are your thoughts on uplifting this to Beta & ESR, Sergey? It grafts cleanly.

Comment 5

[Sergey Galich [:serg]]

[Tracking Requested - why for this release]: it's a simple enough fix that can allow enterprise users edit saved proxy credentials

Comment 6

[Sergey Galich [:serg]]

Attachment: uplift

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: unable to edit saved proxy credentials
Fix Landed on Version:106
Risk to taking this patch (and alternatives if risky): low

ESR Approval Request Comment
[Feature/Bug causing the regression]:n/a
[User impact if declined]:unable to edit saved proxy credentials
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]: yes, https://bugzilla.mozilla.org/show_bug.cgi?id=1748828#c6
[Needs manual test from QE? If yes, steps to reproduce]:no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:no
[Why is the change risky/not risky?]:only affects already failing functionality
[String changes made/needed]:-

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9290341 [details]
Bug 1559205, 1611093, 1748828 - support moz-proxy in about:logins r=dimi!

Seems like a low-risk uplift for a useful ability to have in the enterprise environment. Approved for 105.0b4 and 102.3esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2b162d0cc3b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/c7d4cb4d978b