1611093 - Proxy credentials show the "Discard" dialog for saving changes

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of issue

Affected versions
Nightly 74.0a1 74.0a1 (2020-01-21) (64-bit)
Beta 73.0b8 (64-bit)
Release 72.0.2 (64-bit)

Affected platforms
Windows 10 x64
MacOS 10.15

Steps to reproduce

1. Launch Firefox
2. Set up manual Proxy configuration
3. Go to a site on the same tab to toggle the auth dialog
4. Enter valid credentials and save them
5. Go to about:logins
6. Edit the password and click on "Save Changes"

Expected result
The changes should be saved

Actual Result
The "Discard unsaved changes" dialog appears.
Clicking "Discard" will discard the changes
Clicking "Cancel" will save the changes

This only happens to Proxy credentials, http, ftp and other credentials don't have this issue

Note
Last good build was 71.0a1 (2019-09-17)

Regression-Range
Mozregression found Bug 1579184.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Jared seems to be in parental leave. Sam, could you please take a look at this when you have the time. Thanks!

Comment 2

[Sam Foster [:sfoster] (he/him)]

This is a regression from our old UI, but bug 1579184 is just a CSS change and I don't see how it could have caused this.

Comment 3

[ragimeg698]

The key to copy links is broken. It was removed without a replacement in 88. The tens, maybe hundreds of millions of people who rely on the ability to copy links have had to find solutions outside of Firefox.

Copying links is a core function of a web browser. It is completely unreasonable that this function should be removed. Millions of people use hotkeys. It is an absolutely normal, absolutely acceptable way to interface with a computer.

A "replacement" key that is not physically usable is not a replacement. The function has been removed from Firefox and not replaced.

Since my legitimate reports about this critical bug are being removed, I'm leaving comments on other people's bugs.

---

Comment 4

[Sergey Galich [:serg]]

Moving to P3 as this is not happening in the next release cycle.

Comment 5

[maik.diessner]

I can confirm this issue in the password Firefox manager too. Trying to save changed password will show "discard" dialog instead of "save" dialog sometimes. Thus bug happens since many versions - I've just never reported it yet.

Firefox 103.0.2 (64-bit), Windows 8.1 Pro

Comment 6

[maik.diessner]

Attachment: Passwords.png

Comment 7

[maik.diessner]

Clicking the "Discard" button will save the changed password properly tho.

Comment 8

[Sergey Galich [:serg]]

This bug should be fixed by the fix in Bug 1559205

Comment 9

[Sergey Galich [:serg]]

Fixed by D154925

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

Hi, @Sergey! Could you please provide me with some steps to be able to verify this issue? I followed the steps from the description, but I wasn't able to reproduce this issue using an older version of the Firefox browser.

Comment 11

[Sergey Galich [:serg]]

:srosu sure, you need to have a login saved for moz-proxy://somewhere.com first. Then just try to edit it and click Save, older version should show a message like in Comment 0 or Comment 6.

You can try opening logins.json and modifying URL there manually (replace some https:// with moz-proxy://). That will save you from going through proxy path.

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

Thanks, @Sergey for your reply! I‘ve verified this issue using the latest Firefox Nightly 106.0a1 build (Build ID: 20220918214503), Firefox 102.3.0esr (Build ID: 20220912135840), and Firefox RC 105.0 (Build ID: 20220915150737) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The saved credentials for moz-proxy can be successfully edited without showing the "Discard unsaved changes" pop-up.