155925 - JS error in pref-themes.js

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[[e-mail]]

Error: uncaught exception

Component returned failure code NS_ERROR_INVALID_POINTER

function Startup, line 76

Comment 1

[[e-mail]]

Attachment: Proposed patch

Do a check for the name attribute (doesn't exist on the template :-)

Comment 2

[Eli Friedman]

Attachment: A simpler patch

All that really needs to be changed is the start for the counter.  The first
child of the list is not a theme, but all the other children are.  My patch
changes the code so it starts with the second child.

Comment 3

[Andrew Schultz]

> The first child of the list is not a theme, but all the other children are.

yes, but why!?!?!

Comment 4

[[e-mail]]

>> The first child of the list is not a theme, but all the other children are.
> yes, but why!?!?!
If you had bothered to look in DOM inspector you would know it's a <template>.

Comment 5

[Brant Gurganus]

Full warning text in 2003012408:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIXULChromeRegistry.isSkinSelected]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://communicator/content/pref/pref-themes.js :: Startup :: line 76"  data: no]

Comment 6

[Mike Kowalski]

*** Bug 132242 has been marked as a duplicate of this bug. ***

Comment 7

[Asa Dotzler [:asa]]

we should get this and would consider a fully reviewed patch for the 1.3 branch
but we're not going to hold for this. 

Comment 8

[kinmoz]

Comment on attachment 90325 [details] [diff] [review]
Proposed patch

sr=[e-mail]

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in the patch with reviews (which I prefer too, since it's a little more
robust...)

Comment 10

[Mike Kowalski]

fixed.

Comment 11

[José Jeria]

*** Bug 175392 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Kowalski]

v