1559421 - Add data to Lockwise card

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

This depends on the lockwise team creating an API that can tell us

• the number of stored passwords
• the number of duplicate passwords
• the number of synced passwords

invision mock

Comment 1

[Micah [:mtigley] (she/her)]

Updating what data we'll be hooking up to the Lockwise card in this issue, based on the mockups. In Bug 1559418, we are already using the number of stored logins reported via Services.logins.countLogins. So now what's left is to display the number of synced devices linked to the user's account. We've been provided with some good places to start (thanks Ryan Kelly!):

• The simplest approach is to ping the server everytime the page is loaded using getDeviceAccountsList() from FxAccounts.jsm.
• To avoid doing this, we'll need to take some extra steps, which Ryan has also provided:

1) Checking whether sync has already loaded the list of devices in the background:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#54

2) If it hasn't, showing some placeholder UI and triggering a sync:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#273

3) Getting the list of devices out of sync's "clients" engine, which has a local cache of it:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#64

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1559421 - Report synced devices count on Lockwise card. r=ewright

Comment 3

[Micah [:mtigley] (she/her)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3d953132375125a7d83e193c9e6ce79286a49a4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1274d0f0ce1
Report synced devices count on Lockwise card. r=ewright

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b1274d0f0ce1