Closed Bug 1559421 Opened 6 months ago Closed 5 months ago

Add data to Lockwise card

Categories

(Firefox :: Protections UI, enhancement, P1)

68 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: ewright, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [protection-report][triage])

Attachments

(1 file)

This depends on the lockwise team creating an API that can tell us

  • the number of stored passwords
  • the number of duplicate passwords
  • the number of synced passwords

invision mock

Whiteboard: [protection-report][triage]
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Priority: -- → P1
See Also: → 1559427

Updating what data we'll be hooking up to the Lockwise card in this issue, based on the mockups. In Bug 1559418, we are already using the number of stored logins reported via Services.logins.countLogins. So now what's left is to display the number of synced devices linked to the user's account. We've been provided with some good places to start (thanks Ryan Kelly!):

  • The simplest approach is to ping the server everytime the page is loaded using getDeviceAccountsList() from FxAccounts.jsm.
  • To avoid doing this, we'll need to take some extra steps, which Ryan has also provided:
1) Checking whether sync has already loaded the list of devices in the background:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#54

2) If it hasn't, showing some placeholder UI and triggering a sync:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#273

3) Getting the list of devices out of sync's "clients" engine, which has a local cache of it:

    https://dxr.mozilla.org/mozilla-central/rev/6a2bd09a6bf9aada14581e923408d7308479b76d/browser/base/content/browser-sync.js#64
Depends on: 1559418
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1274d0f0ce1
Report synced devices count on Lockwise card. r=ewright
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.