1559589 - Make Font Editor handle keyword values for line-height

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P1)

Description

[Razvan Caliman [:rcaliman]]

With fixing bug 1536871, the new default value for line-height from getComputedStyle() becomes "normal", not a numeric value.

The Font Editor expects to always be able to parseFloat() the line-height value into a number and that fails resulting in a crashed Font Editor and failed tests.

Similarly to how letter-spacing accepts keyword values, we should ensure components handling line-height follow suit.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Thanks for taking this Razvan!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1559589 - Ensure Font Editor supports "normal" as computed style value for line-height; r=gl

Remove default conversion for line-height value to unitless value to prevent Font Editor from crashing when the patch from Bug 1536871 (the default computed value for line-heightis no longer numeric).

Adds support for normal keyword value for line-height as the default returned by getComputedStyle(), similar to existing behavior for letter-spacing.

Fixes misnomer of the class in LetterSpacing.js component.

Comment 4

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b7dc74db28c84efd9812e7d5e45e6e14991dfca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17cec9244fa9
Ensure Font Editor supports "normal" as computed style value for line-height; r=gl

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/17cec9244fa9