155974 - Need to implement bookmark separators

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect, P2)

Description

[Simon Fraser [no longer active]]

We need to implement support for bookmarks separators. This affects:

1. Bookmark importing (<hr> becomes a separator)
2. Add Separator menu item (needs implementation)
3. Bookmarks drag and drop (separators should not be droppable outside of the
bookmarks window)
4. Bookmarks menu (separators become menu dividers)

Comment 1

[Simon Fraser [no longer active]]

*** Bug 155299 has been marked as a duplicate of this bug. ***

Comment 2

[Max Horn]

In bug 149836 I have a patch that changes the bookmarks to be drawn using a custom 
NSCell subclass. This would make the display part (in the sidebar) trivial, we can just 
add code to the cell subclass. Drawing a seperator in the menu bar is no big deal either.

Of course, that leave the internal representation, I have no clue what would need to be 
done for that. Just wanted to state that the GUI part isn't the issue, at least from my point 
of view.

Comment 3

[Simon Fraser [no longer active]]

Mine

Comment 4

[Rusty Mitchell]

Just wanted to throw my two cents in that I find menu dividers very useful. I
look forward to their addition to Chimera.

Comment 5

[David Haas (gone, not reading mail)]

bug 212630 fixes this

Comment 6

[Mike Pinkerton (not reading bugmail)]

done by 212630