1559946 - The "CFR FxA Bookmark Panel Message" is not correctly adjusted on specific Firefox locales

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 68.0b10, Build ID 20190613141208
• Firefox Nightly 69.0a1, Build ID 20190617214029

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a Firefox fr locale build installed.
• Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to any website and click the "Bookmark this page" button from the right part of the "Address Bar".
3. Observe the "CFR FxA Bookmark Panel Message".

[Expected result]:

• The message is correctly displayed and rendered.

[Actual result]:

• The message is not correctly adjusted.

[Notes]:

• This issue is also reproducible with the Firefox ru locale build.
• Attached a screen recording of the issue.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1559946 - The CFR FxA Bookmark Panel Message has incorrect dimensions in some locales

Comment 2

[Andrei Oprea [:andreio]]

Attachment: french_with_patch

Comment 3

[Andrei Oprea [:andreio]]

Attachment: spanish_without_patch

Comment 4

[Andrei Oprea [:andreio]]

Attachment: spanish_with_patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2084264fac1f
The CFR FxA Bookmark Panel Message has incorrect dimensions in some locales r=r1cky

Comment 6

[Andrei Oprea [:andreio]]

Comment on attachment 9073594 [details]
Bug 1559946 - The CFR FxA Bookmark Panel Message has incorrect dimensions in some locales

Beta/Release Uplift Approval Request

• User impact if declined: We want to launch an experiment in 68 and this patch fixes a small layout issue for some locales
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No risk: feature is hidden behind a pref will be used in an experiment.
  Changes have design r+
• String changes made/needed: n/a

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2084264fac1f

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9073594 [details]
Bug 1559946 - The CFR FxA Bookmark Panel Message has incorrect dimensions in some locales

css fix, approved for 68.0b14

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/56231826b1c8

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190627214735) and latest Firefox Beta (68.0b14 Build ID - 20190627143605) "es-ES" and "fr" locale builds installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. However, this issue is still reproducible with the Firefox "ru" locale build.