1560115 - app.update.interval is not honored

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[sworddragon2]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

1. I did set app.update.interval to 2419200 (4 weeks).
2. On a fixed day every week I did do a manual update check.

Actual results:

On a random moment a doorhanger popped up and noticed me that a new Firefox update was available (from version 67.0.2 to version 67.0.3).

Expected results:

Since I did manual update checks before 4 weeks have been passed an automatic notice that a new update is available sould not have been popped up.

Comment 1

[sworddragon2]

Edit: I forgot to mention in the STR that app.update.checkInstallTime is set to false too.

Comment 2

[Robert Strong (they/them - no direct email)]

The maximum value allowed is 86400 which is 24 hours.

Comment 3

[Robert Strong (they/them - no direct email)]

In case this is related, I am working on a way to improve the update notification experience in bug 1557660 though the implementation in bug 1557660 will likely not be what is implemented.

Comment 4

[sworddragon2]

(In reply to Robert Strong (Robert they/them) [:rstrong] (use needinfo to contact me) from comment #2)

The maximum value allowed is 86400 which is 24 hours.

That involves the question why we can set the preference to higher values. But I guess this is just a limitation of the preferences backend itself as it probably uses 2^32 - 1 as maximum value for every integer - and eventually changing this (like min, max, enum, etc.) might be subject of another ticket.

(In reply to Robert Strong (Robert they/them) [:rstrong] (use needinfo to contact me) from comment #3)

In case this is related, I am working on a way to improve the update notification experience in bug 1557660 though the implementation in bug 1557660 will likely not be what is implemented.

That sounds promising as getting update notifcations while doing a manual check every week is a bit of an issue. And 1 week should be usually good enough for update checks.

But I'm curious why app.update.interval does not suport higher values (at least a few weeks).

Comment 5

[Robert Strong (they/them - no direct email)]

The worst case scenario is an update that fixes an active security exploit and the max value makes it so users will have the update check performed at a maximum of 24 hours.