Closed Bug 1560199 Opened 5 years ago Closed 1 month ago

Add keyboard shortcuts to improve the accessibility of Reader Mode

Categories

(Toolkit :: Reader Mode, enhancement)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1776535

People

(Reporter: akshithashetty84, Unassigned, Mentored)

Details

No description provided.
Assignee: nobody → akshithashetty84
Mentor: eitan
Status: NEW → ASSIGNED
Mentor: yzenevich

The bug assignee didn't login in Bugzilla in the last 7 months.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: akshithashetty84 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(gijskruitbosch+bugs)
Severity: normal → S3

There's a keyboard shortcut to start/stop but none for back/forward, speed, or voice. I think back/forward shortcuts would be useful.

I want to work on this issue, this is not a good first issue and requires so guidance, so I request you guide me accordingly, I searched for the code of existing short-cuts, but I was not able to find the, please guide me. Thanks.

Hi, I would love to work on this task and would appreciate guidance on how to go about it, like the list of keyboard shortcuts required.

Flags: needinfo?(eitan)

Like Simon above I would find back/forward shortcuts most useful

Hi @Gijs. I would appreciate if a'd get a few pointers to help me get started with this bug fix. Like the best place to look to find the code to be edited. Thank you.

Flags: needinfo?(gijskruitbosch+bugs)

https://hg.mozilla.org/mozilla-central/rev/7941091cc105359eeb6af6bbd8375ea3f1762123 added the current shortcut support (using N to start/stop narrate). That should help find the relevant code - the JS moved from NarrateControls.jsm to NarrateControls.sys.mjs.

Flags: needinfo?(gijskruitbosch+bugs)

Okay. Thank you @Gijs for the pointer. I will surely try to follow the code flow and see what solution I can come up with.

Bug 1776535 added forward/backward narration keyboard controls.

Status: NEW → RESOLVED
Closed: 1 month ago
Duplicate of bug: 1776535
Flags: needinfo?(eitan)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.