1776535 - As a user of Firefox ReaderMode I would like a keyboard command to skip narrate backward and forward

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, enhancement, P3)

Description

[Zach Borboa]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:
I tried to find a keyboard command to trigger narrate-skip-next/forward in ReaderMode

Actual results:
To the best of my knowledge this does not exist.

Expected results:
In addition to triggering the narration forward skip of the article while in ReaderMode, there should be some documentation online for how to do this.

Similar to Bug #1749038, but for .narrate-skip-next instead of .narrate-start-stop

Comment 1

[Ania]

Hi Zach!
I think this is a great idea to have a keyboard shortcut for forward in Reader mode. It definitely makes the mode more usable.

Niklas, you worked on the related ticket, and I wonder if you could potentially give this a story point estimate, so we could figure out if we can address this any time soon.

I think it would be reasonable to use -> (arrow right) as a forward shortcut once narration is activated if it's possible.

Comment 2

[Zach Borboa]

+1 on using the right arrow key for the shortcut. thanks!

Comment 3

[[e-mail]]

Would it be too much to ask for back functionality as well as part of this ticket?

Comment 4

[Irene Ni [:ini]]

Attachment: Bug 1776535 - Added keyboard commands to skip narration backward and forward. r=cmkm,eeejay

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50aa70b87099
Added keyboard commands to skip narration backward and forward. r=cmkm,eeejay

Comment 6

[Iulian Moraru]

Backed out for causing bc failures on browser_narrate_toggle.js.

• Push with failures

There are 2 variations of failures for this test:

• Failure log example 1

• Failure log example 2

• Backout link

[task 2024-02-10T07:24:23.684Z] 07:24:23     INFO - TEST-PASS | toolkit/components/narrate/test/browser_narrate_toggle.js | Button tooltip is correct - true == true - 
[task 2024-02-10T07:24:23.685Z] 07:24:23     INFO - Buffered messages finished
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/narrate/test/browser_narrate_toggle.js | first paragraph being spoken - "Chapter 1. Loomings" == "example.com" - got "Chapter 1. Loomings", expected "example.com" (operator ==)
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - Stack trace:
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - is@resource://testing-common/SpecialPowersSandbox.sys.mjs:88:21
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - @chrome://mochitests/content/browser/toolkit/components/narrate/test/browser_narrate_toggle.js:46:7
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - async*execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1654:15
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:257:21
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1385:14
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1583:17
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - spawnInNewReaderTab/<@chrome://mochitests/content/browser/toolkit/components/narrate/test/head.js:71:27
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:146:22
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - async*spawnInNewReaderTab@chrome://mochitests/content/browser/toolkit/components/narrate/test/head.js:57:27
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - testToggleNarrate@chrome://mochitests/content/browser/toolkit/components/narrate/test/browser_narrate_toggle.js:15:9
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - handleTask@chrome://mochikit/content/browser-test.js:1139:26
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1211:18
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1353:14
[task 2024-02-10T07:24:23.687Z] 07:24:23     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1128:14
[task 2024-02-10T07:24:23.688Z] 07:24:23     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-02-10T07:24:23.688Z] 07:24:23     INFO - TEST-PASS | toolkit/components/narrate/test/browser_narrate_toggle.js | back button is enabled - true == true - 

Comment 7

[Irene Ni [:ini]]

I am investigating a fix, thank you for notifying me.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90455402d4bb
Added keyboard commands to skip narration backward and forward. r=cmkm,eeejay

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/90455402d4bb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we should add to the Fx125 relnotes?

Comment 11

[Irene Ni [:ini]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

Is this something we should add to the Fx125 relnotes?

Hi Ryan,
Since the previous bug for a keyboard command to toggle narration on/off was included in the release notes, it could be useful to include this one for visibility.

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]: No
[Suggested wording]: You can now skip Narrate forward and back in Reader View using the left and right arrow keys.
[Links (documentation, blog post, etc)]:

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-02-16 Nightly build on macOS 12.
Verified as fixed on Firefox Nightly 126.0a1 and Firefox 125.0 on macOS 12, Windows 10, Ubuntu 22.