1560359 - Accessibility issues for about:logins

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

I met with Jamie at All Hands and got the following feedback to improve accessibility in about:logins.

1. The login-list <ol> should have tabindex=0 so it is tabbable and also should have role="listbox".
2. The login-list-item elements inside of the login-list <ol> should have role="option"
3. In JS, add support for up/down arrow keys to navigate the selected item
4. Upon selecting an item, focus the Title of the login-item
5. The menu needs to be closeable via keyboard (Esc)

Comment 1

[James Teh [:Jamie]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #0)

3. In JS, add support for up/down arrow keys to navigate the selected item

When the selection is changed, this needs to be exposed as accessibility focus. That can either be done by using tabindex="-1" on the items and focusing them or by setting aria-activedescendant on the listbox to point at the selected item.

5. The menu needs to be closeable via keyboard (Esc)

In addition, the menu needs to be navigable with up/down arrow keys (similar to the listbox).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Matthew N. [:MattN]]

Can you assign a priority please?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1560359 - Add keyboard support for login-list on about:logins.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1560359 - Simplify the markup for menuitems in the menu on about:logins.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1560359 - Add keyboard support for the menu on about:logins.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba5bdea1b608
Add keyboard support for login-list on about:logins. r=fluent-reviewers,sfoster,flod,yzen
https://hg.mozilla.org/integration/autoland/rev/2c0e25c99a72
Simplify the markup for menuitems in the menu on about:logins. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/040ec473bc01
Add keyboard support for the menu on about:logins. r=sfoster,yzen

Comment 8

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser_openPreferences.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=040ec473bc013501896c79a1e64a069d1aabe9a9&selectedJob=254466098

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254466098&repo=autoland&lineNumber=6768

Backout: https://hg.mozilla.org/integration/autoland/rev/7575aaa9db33b9a44f5446fe1bc407d2d057f82a

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a47da25dc196
Add keyboard support for login-list on about:logins. r=fluent-reviewers,sfoster,flod,yzen
https://hg.mozilla.org/integration/autoland/rev/2bfbb6633d3a
Simplify the markup for menuitems in the menu on about:logins. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/f9bbfd8ef2b0
Add keyboard support for the menu on about:logins. r=sfoster,yzen

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a47da25dc196
https://hg.mozilla.org/mozilla-central/rev/2bfbb6633d3a
https://hg.mozilla.org/mozilla-central/rev/f9bbfd8ef2b0

Comment 11

[James Teh [:Jamie]]

There are currently two problems with this:

1. aria-activedescendant isn't working in the account list due to bug 1566324.
2. The arrows don't work as expected initially in the menu; see bug 1566321.