1566321 - [a11y] Arrow keys do not work in about:logins menu unless tab is pressed first

Status: RESOLVED FIXED

(Firefox :: about:logins, defect, P2)

Description

[James Teh [:Jamie] (away returning 28 Jan)]

Bug 1560359 made the about:logins menu keyboard accessible. However, the arrow keys don't work unless you first focus a menu item with the tab key.

STR:

1. Enable the pref signon.management.page.enabled .
2. Visit about:logins .
3. Tab to the button to open the menu.
4. Press enter to activate it.
5. Press down arrow.
   • Expected: The first menu item should be focused.
   • Actual: It isn't.

Note that if you press tab before down arrow, down arrow does work after that.

Comment 1

[Marco Zehe (:MarcoZ)]

In most menus of this type, the first menu item should be focused automatically after pressing the button, should it not? Should that happen as a fix for this bug as well?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The original patch did focus the first item in the menu when it opened, but I removed that due to a review comment. It can be added back in easily.

Comment 3

[Sam Foster [:sfoster] (he/him)]

[Tracking Requested - why for this release]:

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

I don't think release management needs to specially track this, though it would be nice to fix for 70. Jaws, do you want to take this on?

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1566321 - Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws

Comment 6

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa911a74e62f8b04a890a217c12e8f2cbc515b8d

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:ntim, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 8

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eff3f17a12cf5945f981b06e8bb6b202862b735e

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af667e4c7419
Make meatball menu keyboard navigation match WAI-ARIA authoring practices. r=Jamie,jaws

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/af667e4c7419

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval if you're comfortable doing so. It'll need a rebased patch if so, however.