1560402 - A specific pane is not selected in the Account manager in a tab

Status: RESOLVED WONTFIX

(Thunderbird :: Account Manager, defect)

Description

[:aceman]

There are cases where we call the Account manager to open directly with a specific pane of the account via MsgAccountManager(pane). This does not work after bug 1096006.

Comment 1

[:aceman]

Attachment: 1560402.patch

You can test this by clicking an IMAP account, showing the Account central page and then clicking the "Offline settings" (last item). Without the patch it selects the first pane (account name) in the account manager, not the Offline settings pane.

Comment 2

[:aceman]

Attachment: 1560402.patch v2

Now with passing tests:)
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4559a5e8aa01305fb4b1fde5681238cfe1fb213d

Looks like this fixes behaviour in test-mail-account-setup-wizard.js and uncovers a logic bug in the AM that we must clear currentAccount when deleting an account/rebuilding the tree as otherwise checks are run on the already removed account data and fail.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073149 [details] [diff] [review]
1560402.patch v2

Yes, this works now (but it wasn't a drama that this little used feature didn't take you exactly to the spot) :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ad5f1f559f7
Pass the wanted account manager pane via openPreferencesTab() properly. r=jorgk

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b01d4da30db
Backed out changeset 0ad5f1f559f7, not necessary after backout of AM in pref tab. a=backout