1560416 - Picture-in-Picture toggle displays when video metadata is still being downloaded, even when supposedly disabled

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Ensure the Picture-in-Picture toggle is disabled (set media.videocontrols.picture-in-picture.video-toggle.enabled to false).
2. Visit this slideshow
3. Click on the "Play" button in the center of the video, and keep your mouse cursor centered on the video.

ER:

As the video loads, the Picture-in-Picture toggle icon is not displayed.

AR:

As the video loads, the Picture-in-Picture toggle icon is displayed, but then goes away after the video metadata has finished loading.

I suspect this was regressed by my patch for bug 1555834.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

It turns out that this has been a problem for a while, and wasn't regressed by bug 1555834.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Mozregression says this was regressed by bug 1547795.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1560416 - Hide the Picture-in-Picture toggle by default when initializing a video binding. r?JSON_Voorhees

Later, once we have enough video metadata, the binding will decide whether or not to display the toggle again.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75c588f5f225
Hide the Picture-in-Picture toggle by default when initializing a video binding. r=JSON_voorhees

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/75c588f5f225

Comment 6

[Cristian Craciun]

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build on Windows 10.

On Windows 7 the issue is still reproducible, the toggle is displayed for a second when the play button is pressed. Could you please take a look?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hm... I'm not seeing it:

https://www.screencast.com/t/P2h8F73Bi

Am I skipping a step?

Comment 8

[Cristian Craciun]

Build ID 20190627214735
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Build ID 20190627214735
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

I've tested today with the latest Nightly build on both Windows 10 and Windows 7 and the toggle is not displayed anymore on the demo page, even when the media.videocontrols.picture-in-picture.video-toggle.enabled is set to true. On youtube and other websites the toggle is displayed.

When the preference media.videocontrols.picture-in-picture.video-toggle.enabled is set to false, the toggle is not displayed on any website.

Comment 9

[Cristian Craciun]

Hi Mike, could you please take a look over the Comment 8?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

(In reply to Cristian Craciun from comment #8)

I've tested today with the latest Nightly build on both Windows 10 and Windows 7 and the toggle is not displayed anymore on the demo page, even when the media.videocontrols.picture-in-picture.video-toggle.enabled is set to true. On youtube and other websites the toggle is displayed.

Hi Cristian,

Yeah, I don't think this video was ever actually meant to display the toggle - it's not fitting the criteria for a "qualifying video" for showing the toggle (see bug 1547795 comment 0). In this case, it's both a silent video, and too short to show the toggle.

Comment 11

[Cristian Craciun]

Thank you for the clarification.

Verified as fixed based on Comment 10.