1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it.

This makes running without mach more consistent. e.g. running
make -C $objdir/toolkit/library/rust target makes the cargo log
verbose, and adding -s makes it less verbose.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2901d32eddaa
Enable make backend verbose mode automatically rather than relying on mach setting it. r=froydnj

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9073194 [details]
Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it.

Beta/Release Uplift Approval Request

• User impact if declined: Incomplete logs when building with make directly, which is common downstream. Nice to have for esr68.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Practically a no-op for mozilla builds, which use mach.
• String changes made/needed:

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2901d32eddaa

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9073194 [details]
Bug 1560527 - Enable make backend verbose mode automatically rather than relying on mach setting it.

A+, NPOTB

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2bee7577b5a6