1560580 - Isolate Font Cache by OriginAttributes

Status: RESOLVED DUPLICATE of bug 1647732

(Core :: Layout: Text and Fonts, task, P3)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

There is a pref gfx.downloadable_fonts.disable_cache which disables the font cache. Ideally we would isolate this cache by Origin Attributes.

Currently we isolate it with a hash key here: https://searchfox.org/mozilla-central/rev/c0ca77697c6868482f30af873ec8069f2c080a34/gfx/thebes/gfxUserFontSet.h#398-410

But the principal does not, as far as I can tell, take into account OriginAttributes. Isolating by OriginAttributes would also remove the need for the Private Browsing ID

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Jonathan Kew [:jfkthame]]

Can you provide a testcase for this? (This really isn't an area I know much about.) It looks like we could easily add an OriginAttributes comparison to gfxFontSrcPrincipal::Equals to make them compare as unequal if the attrs differ; would that resolve this issue?

Comment 4

[Tim Huang[:timhuang]]

Actually, gfxFontSrcPrincipal::Equals() already checks OAs. See here, we use BasePrincipal::FastEquals() to check equality and it also checks the originSuffix, which is the OAs. However, the hash doesn't take the OAs into account because this hash is generated by nsIPrincipal::GetHashValue() and it only respects the domain of the principal.

So, I think we also need to change the hash to include the OAs for isolating the font cache.

Comment 5

[Gary Chen [:xeonchen]]

(In reply to Jonathan Kew (:jfkthame) from comment #2)

Can you provide a testcase for this? (This really isn't an area I know much about.) It looks like we could easily add an OriginAttributes comparison to gfxFontSrcPrincipal::Equals to make them compare as unequal if the attrs differ; would that resolve this issue?

I have a simple WIP patch of this, but I don't know much about how to test it under gfx's world.

My idea is creating a page http://foo.com/custom_font.html containing a custom font embedded by both http://a.com/test_font_cache.html and http://b.com/test_font_cache.html.
The font should be isolated in different cache.

Jonathan, could you give me some idea how to write a test on fonts' side? Is there any existing test for font cache?

Comment 6

[Jonathan Kew [:jfkthame]]

I don't remember in detail exactly what it's doing, but you might be able to use ideas from layout/style/test/test_redundant_font_download.html, which uses a custom .sjs server to provide a webfont resource and keep track of what requests have been made. That sort of technique should allow you to check whether a resource is being used from cache or requested separately for each origin, I think.

Comment 7

[Gary Chen [:xeonchen]]

Attachment: 0001-Bug-1560580-Add-originSuffix-into-font-hash.patch

This is my (WIP) patch of adding origin attributes to the hash for the UserFontCache, but I don't have a working test. Anyone is welcome to continue the work.

We're going to isolate network cache of font on bug 1647732.

Comment 8

[Gary Chen [:xeonchen]]

The patch has landed in bug 1647732.

Comment 9

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

In bug 1647732, I don't see any reference to first party isolation; nor a test for it. When FPI is enabled, is the Font Cache isolated; or is it only when dFPI is enabled?

Comment 10

[Tim Huang[:timhuang]]

The test was added in here. And it tests originAttributes in general. So, I believe it works for both FPI and dFPI.