1560600 - Don't allow WebRender for AMD on non-nightly for non-Windows platforms

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Andrew Osmond [:aosmond] (he/him)]

As titled, we shouldn't allow qualified WebRender at this moment on non-Windows (e.g. AMD + Linux => WebRender on nightly, basic on beta/release) for AMD devices unless it is nightly. There are still bugs to resolve before this can ship (see wr-linux).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1560600 - Don't allow WebRender for AMD on non-nightly for non-Windows platforms.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

This is getting kind of annoying to manage with all the different combinations of devices, platforms, and channels. We should reorganize this code so it's more obvious what is enabled where and make it easier to enable more configurations (as a follow-up bug)

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)

This is getting kind of annoying to manage with all the different combinations of devices, platforms, and channels. We should reorganize this code so it's more obvious what is enabled where and make it easier to enable more configurations (as a follow-up bug)

Agreed, I had the same thought. I'll file a bug about this and see what can be done...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60c8d0cdd443
Don't allow WebRender for AMD on non-nightly for non-Windows platforms. r=kats

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/60c8d0cdd443

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9073280 [details]
Bug 1560600 - Don't allow WebRender for AMD on non-nightly for non-Windows platforms.

Beta/Release Uplift Approval Request

• User impact if declined: Linux users with AMD graphics cards may get WebRender in beta/release when we did not expect them to.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a trivial build time check to disable WebRender for certain OS/release channel/hardware configurations.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9073280 [details]
Bug 1560600 - Don't allow WebRender for AMD on non-nightly for non-Windows platforms.

approved for 68.0b14

Comment 8

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/1d577a6a7cd1

Comment 9

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=66f621aa4cfa7d3edb7a410a8c98c9b3d8c8a13c&selectedJob=253342914

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253342914&repo=mozilla-beta&lineNumber=26214

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/90725f025a3b433f0bf0d69359905b51c3711d6a

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

Reasons got added in bug 1556007 which I didn't request uplift for. We don't need to take it, I will just use the old reason.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29eb6d860ff3b49b34cbffe39bd64f23f4441e42

Comment 11

[Andrew Osmond [:aosmond] (he/him)]

Attachment: uplift for beta, v1

Comment 12

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9073912 [details] [diff] [review]
uplift for beta, v1

Beta/Release Uplift Approval Request

• User impact if declined:
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Same as comment 6, but I tweaked the error code because of a missing uplift dependency (which is unimportant, it just expands our error code list and we can use an existing one in beta).
• String changes made/needed:

Comment 13

[Julien Cristau [:jcristau]]

Actually wouldn't this be blocked on mac and linux by https://hg.mozilla.org/releases/mozilla-beta/file/1d1f44e16b8ac54b14a32a2ce170b4022f9a6e43/widget/cocoa/GfxInfo.mm#l311 and https://hg.mozilla.org/releases/mozilla-beta/file/1d1f44e16b8ac54b14a32a2ce170b4022f9a6e43/widget/GfxInfoX11.cpp#l350? 68 doesn't have bug 1554251 so AFAICT isn't actually affected by this.
(The nvidia case also doesn't have an explicit check for windows in WebRenderHardwareQualificationStatus().)

Comment 14

[Julien Cristau [:jcristau]]

Confirmed on irc this isn't an issue before 1554251.

Comment 15

[Timea Zsoldos [:tzsoldos], Desktop QA]

Hi Andrew Osmond,
I am trying to verify this issue and to be able to do that can you please help me with a list that contains supported AMD graphics cards? I need this to be able to reproduce this issue.
I tested on AMD Radeon (TM) Rx 480 Graphics, Ubuntu platform 67.0, 68.0 -> Compositing: Basic
Nightly from 2019.06.21 -> Compositing: Basic
latest Nightly 69.0a1 (2019.07.02) -> Compositing: Basic
Thank you!

Comment 16

[Andrew Osmond [:aosmond] (he/him)]

I think that AMD card should be qualified, it might be your Mesa version. Can you attach your about:support? Thanks!

Comment 17

[Timea Zsoldos [:tzsoldos], Desktop QA]

Attachment: WebRenderLatestNightly

Comment 18

[Timea Zsoldos [:tzsoldos], Desktop QA]

Attachment: WebRender68.0

Comment 19

[Timea Zsoldos [:tzsoldos], Desktop QA]

I attached the about:support for Fx 69.0a1 latest nightly and Fx 68.0.

Comment 20

[Darkspirit]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #17)

"osVersion": "Linux 4.13.0-38-generic",
"windowLayerManagerType": "Basic",
"adapterDescription": "AMD Radeon (TM) RX 480 Graphics",
"adapterVendorID": "0x1002",
"adapterDeviceID": "AMD Radeon (TM) RX 480 Graphics",
"adapterRAM": "0MB",
"adapterDrivers": "",
"driverVendor": "ati/unknown",
"driverVersion": "",
"driverDate": "",
"webgl1Renderer": "WebGL creation failed: \n* Refused to create native OpenGL context because of blacklist entry: FEATURE_FAILURE_OLD_FGLRX\n* Exhausted GL driver options.",
"webgl2Renderer": "WebGL creation failed: \n* Refused to create WebGL2 context because of blacklist entry: FEATURE_FAILURE_OLD_FGLRX",

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #15)

Ubuntu

Thanks!
https://packages.ubuntu.com/xenial-updates/linux-image-4.13.0-38-generic
Ubuntu 16.04 is not supported: For WebRender, you need at least Ubuntu 18.04 LTS, which has "Mesa 18.2 or newer".
Ubuntu 18.04 LTS should have xserver-xorg-video-amdgpu installed by default. Optionally, a newer driver is available via xserver-xorg-video-amdgpu-hwe-18.04.

Comment 21

[Timea Zsoldos [:tzsoldos], Desktop QA]

I've checked on Windows 10 x64, using Fx 68.0 and 67.0 Webrender is ON by default, however on Ubuntu 18.04 with AMD RX550 it's only ON by default on Nightly (Compositing: WebRender).