1560608 - Set a maxVersion of 69 for Lockwise extension and update the description to tell users the feature is built-in now

Status: VERIFIED FIXED

(Firefox :: about:logins, task, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

We're planning on shipping Lockwise built-in to Firefox in 70, and thus the Lockwise extension will be obsolete. We should set the maxVersion of the extension to 69 so it will disable itself automatically, then we can have the extension uninstall itself or update the description to explain that the extension is now built-in to Firefox.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Matthew, is this something you can help out with?

Comment 3

[Matthew Miller [:m_and_m]]

Yes, I can help out. I should be able to have a PR in that repo up by the start of next week.

If we can update https://github.com/mozilla-lockwise/lockwise-addon/issues/188 with this directly, that would help.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Matthew, are you still working on this ? Or do you already have a patch?

Comment 5

[Matthew Miller [:m_and_m]]

This has been patched:

• add-on manifest: https://github.com/mozilla-lockwise/lockwise-addon/pull/334
• updates manifest: https://github.com/mozilla-lockwise/mozilla-lockwise.github.io/pull/138
• Add-on release: https://github.com/mozilla-lockwise/lockwise-addon/pull/338
• Add-on deployment: https://github.com/mozilla-lockwise/mozilla-lockwise.github.io/pull/140

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Great, want to close the bug? Or, is there anything left to do here?

Comment 7

[Matthew Miller [:m_and_m]]

I think we can close it; will do so now.

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on Firefox Beta 70.0b3 and the latest Nightly 71.0a1 build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The Lockwsie extension is successfully disabled after updating the Nightly 69.0a1 build to Nightly 70.0a1. Also, the "feature is built-in Firefox" message is correctly displayed in "about:addons" on the disabled Lockwise extension.
• The Lockwsie extension is successfully disabled after updating the Firefox Beta 69.0bx to Beta 70.0b3. Also, the "feature is built-in Firefox" message is correctly displayed in "about:addons" on the disabled Lockwise extension.