156113 - Calendar should use VALUE=DATE parameter for all-day events instead of X prop

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[ajbu]

I was almost sure I entered this before, but can't find it..
Currently Calendar uses a X property to specify an allday event, and sets :
X
 ;MEMBER=AllDay
 :TRUE
DTSTART
 :20020429T000000
DTEND
 :20020429T235900

It would be better to use the VALUE parameter DATE to specify the allday event

From the iTip rfc:
4.1.5 Anniversaries or Events attached to entire days

   This example demonstrates the use of the "value" parameter to tie a
   "VEVENT" to day rather than a specific time.

   BEGIN:VCALENDAR
   PRODID:-//ACME/DesktopCalendar//EN
   METHOD:PUBLISH
   VERSION:2.0
   BEGIN:VEVENT
   ORGANIZER:mailto:[e-mail]
   DTSTAMP:19970614T190000Z
   UID:[e-mail]
   DTSTART;VALUE=DATE:19970714
   RRULE:FREQ=YEARLY;INTERVAL=1
   SUMMARY: Bastille Day
   END:VEVENT
   END:VCALENDAR

Comment 1

[ajbu]

This should be very easy to do, the icaltimetype has a property is_date.
setting if(m_allday) m_datetime.isdate = 1 should be enough to store an 
alldate event for iCalendar.

Comment 2

[ajbu]

Attachment: Patch for oeICalEventImp.cpp to convert allday property

Patch that writes m_allday boolean in the DTSTART value.
DTSTART of an allday event becomes:
DTSTART
 ;VALUE=DATE
 :20020708

Parser is still reading the X allday property, so importing holidays still
works. X property is no longer written.
When allday is true, DTEND is no longer written.

Comment 3

[Mike Potter]

This is for Mostafa.

Comment 4

[Mostafa Hosseini]

Throughout the code the assumption is that the m_datetime variable is a complete
datettime value specially in the recurrence calculating code. So the previous
patch needs to be revised to make sure this assumption is kept true. I will
attach the revised patch and wait for Arentjan to comment on it.

Comment 5

[Mostafa Hosseini]

Attachment: Revised patch for allday property

Comment 6

[ajbu]

New patch looks good to me.

Comment 7

[Mostafa Hosseini]

Fixed in CVS

Comment 8

[ajbu]

Patch in CVS has a typo, 'is_date == false' should be 'is_date = false'

+            m_start->m_datetime.is_date == false; //Because currently we 
depend on m_datetime being a complete datetime 

Comment 9

[Brant Gurganus]

Default QA Contact for Calendar has changed.  If you wish to remain the QA
contact for this bug, feel free to change it back.

Comment 10

[Marcia Knous [:marcia]]

Mass move of libxpical bugs to the Internal Components, per ctalbert.

Comment 11

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!